Skip to content

adds reflectionCache #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jagepard merged 1 commit into from
May 20, 2025
Merged

adds reflectionCache #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/Router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ class Router implements RouterInterface
use SetRudraContainersTrait;
use RouterRequestMethodTrait;

protected array $reflectionCache = [];

/**
* @param array $route
* @return void
Expand Down Expand Up @@ -198,11 +200,15 @@ protected function callActionThroughReflection(?array $params, string $action, o
throw new RouterException("404");
}

$reflection = new \ReflectionClass($controller);
$method = $reflection->getMethod($action);
$cacheKey = get_class($controller) . "::$action";
if (!isset($this->reflectionCache[$cacheKey])) {
$this->reflectionCache[$cacheKey] = [
'method' => new \ReflectionMethod($controller, $action),
];
}

$method = $this->reflectionCache[$cacheKey]['method'];
$arguments = $this->rudra()->getParamsIoC($method, $params);

$method->invokeArgs($controller, $arguments);
}

Expand Down
Loading