fix(ci): add ignore-vulns input to pip-audit reusable workflow#139
Closed
JacobPEvans wants to merge 6 commits intomainfrom
Closed
fix(ci): add ignore-vulns input to pip-audit reusable workflow#139JacobPEvans wants to merge 6 commits intomainfrom
JacobPEvans wants to merge 6 commits intomainfrom
Conversation
Allows callers to pass vulnerability IDs to ignore when no fix is available upstream (e.g. CVE-2026-4539 in pygments 2.19.2). (claude)
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional input to the org-wide reusable Python dependency security scan workflow so callers can ignore specific pip-audit vulnerability IDs (e.g., a CVE without an upstream fix).
Changes:
- Introduces
ignore-vulnsas an optionalworkflow_callinput with a default empty string. - Builds
--ignore-vulnarguments from the input and appends them to thepip-auditinvocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobPEvans
added a commit
to JacobPEvans/nix-ai
that referenced
this pull request
Mar 26, 2026
Add .osv-scanner.toml to acknowledge GHSA-5239-wwwm-4pmq (pygments ReDoS in AdlLexer) which has no upstream fix. Pass ignore-vulns to pip-audit reusable workflow for the same CVE. Depends on: JacobPEvans/.github#139 (claude)
3 tasks
JacobPEvans
added a commit
to JacobPEvans/nix-ai
that referenced
this pull request
Mar 26, 2026
Reference _python-security.yml from fix/pip-audit-ignore-vulns branch which accepts the ignore-vulns input. Revert to @main after JacobPEvans/.github#139 merges. (claude)
Allows callers to pass a path to osv-scanner.toml via --config flag, which applies ignore rules globally to all scanned lockfiles. (claude)
Add --no-editable to uv export to prevent pip-audit from failing on editable package references that cannot be hash-verified. (claude)
Strip bare '.' and '-e' lines from uv export output to prevent pip-audit from failing on local directory references that cannot be hash-verified. (claude)
5 tasks
Replaces string concatenation with a bash array for building --ignore-vuln arguments, preventing potential command injection via shell metacharacters. Removes the SC2086 shellcheck suppression that was masking the issue. Adds 'vulns' to cspell dictionary. (claude)
…vulns # Conflicts: # .cspell.json # .github/workflows/_python-security.yml
Owner
Author
|
Superseded by #143 — centralizing OSV ignores via osv-scanner.toml instead of per-caller workflow inputs. The central config approach avoids DRY violations when multiple repos need the same ignores. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignore-vulnsinput to_python-security.ymlreusable workflow, allowing callers to pass vulnerability IDs to suppress known false positives (e.g., CVE-2026-4539)configinput to_osv-scan.ymlfor passing anosv-scanner.tomlconfig file--ignore-vuln GHSA-5239-wwwm-4pmqwith dynamic caller-provided inputChanges
_python-security.yml: Newignore-vulnsinput builds a bash array of--ignore-vulnflags; uses--no-emit-projectfor clean requirements export_osv-scan.yml: Newconfiginput passes--configto osv-scanner when provided.cspell.json: Addsvulnsto spell-check dictionaryTest plan
ignore-vulnscontinue to work (default empty string, array expands to nothing)ignore-vulns: 'GHSA-5239-wwwm-4pmq'and pip-audit succeeds