Conversation
…us reporting. Replace PrStagingDeployCommentUpdateQueue and related background service with StagingErrorWatcherQueue and StagingErrorWatcherBackgroundService for improved monitoring of deployment failures. Update GitHubApiClient to fetch pull request merge info, ensuring accurate deployment state checks. Modify PrStagingDeployCommentService to streamline comment updates and error reporting. (#422)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Race condition fix — before creating Sliplane services, check GitHub API
that the PR is still
open. If it was already merged or closed (fast merge),the deploy is skipped silently — no more
Branch does not exist/Internal server errorfrom Sliplane.A short delay (
Staging:PreDeployDelayMs, default 1200 ms) is added aftertearing down old services so a concurrent
closedwebhook can win the race.Simplified PR comments — removed the old background polling queue that
blocked all PRs in a single-reader channel (up to 30 min per PR).
Now: links are posted immediately after service creation; only if the
Sliplane build later fails is the comment replaced with an error.
StagingErrorWatcherBackgroundService — lightweight replacement.
Runs concurrently per PR (no head-of-line blocking), polls Sliplane events
every 5 s for up to 20 min, updates the comment only on build failure.
Removed
PrStagingDeployCommentUpdateQueue,PrStagingDeployCommentUpdateBackgroundService,SliplaneDeploymentStatusResolver(no longer needed).Comment format
### Staging preview+ Docs/Samples links### Staging deploy failed+ error from Sliplane### Staging removed