Skip to content

[pr-staging-deploy]: Improve PR staging deploy comments: reliability, partial status, and Sliplane listing merge#421

Merged
rorychatt merged 1 commit intomainfrom
fix/pr-staging-deploy-comments-and-status
Apr 3, 2026
Merged

[pr-staging-deploy]: Improve PR staging deploy comments: reliability, partial status, and Sliplane listing merge#421
rorychatt merged 1 commit intomainfrom
fix/pr-staging-deploy-comments-and-status

Conversation

@ArtemLazarchuk
Copy link
Copy Markdown
Collaborator

Summary

Improves the PR Staging Deploy sample so GitHub PR comments stay accurate and easier to reason about when Sliplane is slow or only one service succeeds.

Changes

  • Immediate progress comments after a deploy/redeploy is queued (Deploy in progress, Redeploying staging, Checking staging deployment) so threads do not look stuck after e.g. “Deleted”.
  • Comment refresh model: remove all prior marker comments (<!-- ivy-staging-deploy -->) with retries, then post a new comment each time (matches desired “always fresh” thread behavior).
  • Status resolution: merge per-service state from Sliplane events + listing on every poll (not only after a long delay), so “pending” clears sooner when listing is already live.
  • Partial deployments: if Docs and Samples diverge (one live, one failed, or one not provisioned), post a Partial deployment comment with per-service lines and logs focused on the failed side.
  • URL gating: when posting “Deployed”, only require URLs for services that were actually created.
  • GitHub API: treat 404 on comment delete as success (idempotent cleanup).

Notes

  • End-to-end behavior still depends on Sliplane and GitHub availability; this reduces “silent” periods and misleading all-failed messaging when only one wing fails.

…Service and update background service for improved status resolution. Add StagingCommentPartialBreakdown record to encapsulate deployment states and URLs. Enhance comment body construction to support partial deployment scenarios, ensuring accurate status reporting for both docs and samples. (#421)
@ArtemLazarchuk ArtemLazarchuk requested a review from rorychatt April 3, 2026 08:39
@ArtemLazarchuk ArtemLazarchuk self-assigned this Apr 3, 2026
@rorychatt rorychatt merged commit b8c8a5c into main Apr 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants