Conversation
…Service and update background service for improved status resolution. Add StagingCommentPartialBreakdown record to encapsulate deployment states and URLs. Enhance comment body construction to support partial deployment scenarios, ensuring accurate status reporting for both docs and samples. (#421)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the PR Staging Deploy sample so GitHub PR comments stay accurate and easier to reason about when Sliplane is slow or only one service succeeds.
Changes
Deploy in progress,Redeploying staging,Checking staging deployment) so threads do not look stuck after e.g. “Deleted”.<!-- ivy-staging-deploy -->) with retries, then post a new comment each time (matches desired “always fresh” thread behavior).live.404on comment delete as success (idempotent cleanup).Notes