Skip to content

Conversation

@Rongix
Copy link
Collaborator

@Rongix Rongix commented Jan 29, 2025

Changes:

  • Support latest dependencies version for analyzer, source_gen
  • Change Dart SDK constraints

@Rongix
Copy link
Collaborator Author

Rongix commented Jan 29, 2025

@DelcoigneYves
Copy link

@mjablecnik I saw you approved, but it does not count towards the total approvers, so can't be merged, can you double-check please? 🙏

@mjablecnik
Copy link

@DelcoigneYves I don't know why it is not counted towards the total approvers. I made code review and approved it and I don't have any other things what I can do.
Tell me what additionally I have to do and I will do it.

@mjablecnik
Copy link

@DelcoigneYves I do not have any other approve button here..

@DelcoigneYves
Copy link

Weird, this is what I see in the reviewers column:
image

@Rongix Maybe you can see something more?

@@ -1,3 +1,8 @@
# 3.0.2
Copy link

@vasilich6107 vasilich6107 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this could be 4.0.0 as far as we are having a breaking change.

by bumping analyzer to next major version
analyzer: ">=7.0.0 <8.0.0"

and dart
dart: ">=3.0.0 <4.0.0"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not count dependencies upgrade as a breaking change, we didn't change any API in this release. Pub won't upgrade this version in your project if dependencies are not compatible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying

@vasilich6107
Copy link

Hi @mjablecnik

I can see that previous PRs were approved by @AndriiChemer in addition to @RSC-88
Probably @AndriiChemer could help with this

@Rongix Rongix merged commit a8b469c into main Feb 13, 2025
1 check passed
@Rongix Rongix deleted the rc/3.0.2 branch February 13, 2025 21:43
@vasilich6107
Copy link

@Rongix could you release this version

@vasilich6107
Copy link

@mjablecnik @AndriiChemer @RSC-88 - any chance to release

@vasilich6107
Copy link

Hi
@Rongix @mjablecnik @AndriiChemer @RSC-88
Is there any reason not to release the updated version?

@vasilich6107
Copy link

vasilich6107 commented Feb 26, 2025

Hi
@Rongix @mjablecnik @AndriiChemer @RSC-88 @tomkad99
Is there any reason not to release the updated version?

@simon-the-shark
Copy link

@Rongix @mjablecnik @AndriiChemer @RSC-88 @tomkad99
Bump. Is there any reason not to release the updated version?

@mjablecnik
Copy link

@Rongix Can you release latest changes?

@umbrellait-timur-khismatullin

Rooooooooooongix release please! @Rongix

@Rongix
Copy link
Collaborator Author

Rongix commented Mar 12, 2025

Hi. The update is now available on pub.dev.

@vasilich6107
Copy link

Thanks @Rongix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants