Skip to content

[DEPLOY] production-release(v.0.3.x) #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taerimiiii merged 1 commit into from
Jun 18, 2026
Merged

[DEPLOY] production-release(v.0.3.x) #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/issueissyu/backend/domain/issue/entity/IssuePin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,16 @@ public class IssuePin extends BaseEntity {
public void incrementPetitionCount() {
this.petitionCount++;
}

public void markInProgressIfBeforeProgress() {
if (this.issuePinState == IssuePinState.BEFORE_PROGRESS) {
this.issuePinState = IssuePinState.IN_PROGRESS;
}
}

public void markResolvedIfInProgress() {
if (this.issuePinState == IssuePinState.IN_PROGRESS) {
this.issuePinState = IssuePinState.RESOLVED;
}
}
}
4 changes: 4 additions & 0 deletions ...java/issueissyu/backend/domain/issue/service/command/ProblemSolverCommandServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ public GoNowResDTO participateGoNow(Long pinId, String uid) {
throw ProblemSolverException.of(IssueErrorCode.GO_NOW_400_1);
}

issuePin.markInProgressIfBeforeProgress();

@gemini-code-assist gemini-code-assist Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

issuePin.getIssuePinState() == IssuePinState.RESOLVED state check is missing. imagine an issue that is already resolved, new solvers should not be allowed to participate. import and add a check before proceeding.

also, markInProgressIfBeforeProgress() should be called before saveAndFlush to keep the state consistent.

        if (issuePin.getIssuePinState() == issueissyu.backend.domain.issue.enums.IssuePinState.RESOLVED) {
            throw ProblemSolverException.of(IssueErrorCode.GO_NOW_400_1);
        }
        issuePin.markInProgressIfBeforeProgress();


return GoNowResDTO.builder()
.pinId(pinId)
.problemSolverId(saved.getProblemSolverId())
Expand Down Expand Up @@ -198,6 +200,8 @@ public ProblemSolverCheckResDTO resolveCitizenVerification(Long problemSolverId,
solver.markResolved();
problemSolverRepository.save(solver);

solver.getIssuePin().markResolvedIfInProgress();

@gemini-code-assist gemini-code-assist Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

calling markResolvedIfInProgress() after saving the solver is a bit inconsistent. since the method is @transactional, dirty checking will save it, but it is better to modify all states before calling save, or even better, remove the explicit save call and rely on dirty checking.


return ProblemSolverCheckResDTO.builder()
.problemSolveState(ProblemSolveState.RESOLVED.name())
.build();
Expand Down
Loading