Skip to content

[DEPLOY] production-release(v.0.2.8) #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaaan7 merged 5 commits into from
Jun 15, 2026
Merged

[DEPLOY] production-release(v.0.2.8) #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0aedf7
feat: cardnews 피드 조회 추가
yaaan7 Jun 15, 2026
4f95d8c
refactor: 쿼리문 수정
yaaan7 Jun 15, 2026
cb0483d
Merge pull request #350 from IssueIssyu/feat/349-cardnews-feed
yaaan7 Jun 15, 2026
5da392a
fix: 새 도메인 url로 변경~!
yaaan7 Jun 15, 2026
e8c6561
Merge pull request #354 from IssueIssyu/bug/353-swagger-url
yaaan7 Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/main/java/issueissyu/backend/domain/community/repository/CommunityRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,33 @@ List<Community> findFeedByType(
Pageable pageable
);

/**
* CARDNEWS 탭 피드 조회.
*
* 정책/공모전 중 카드뉴스 이미지가 연결된 커뮤니티만 조회한다.
* 지역 조건은 사용하지 않는다.
*/
@Query("""
select c
from Community c
join fetch c.pin p
join fetch p.user
where c.communityType in :types
and c.cardnewsImages is not empty
and (
cast(:cursorCreatedAt as LocalDateTime) is null
or c.createdAt < :cursorCreatedAt
or (c.createdAt = :cursorCreatedAt and c.communityId < :cursorId)
)
order by c.createdAt desc, c.communityId desc
""")
List<Community> findCardnewsFeedByTypesWithImages(
@Param("types") Collection<CommunityType> types,
@Param("cursorCreatedAt") LocalDateTime cursorCreatedAt,
@Param("cursorId") Long cursorId,
Pageable pageable
);

/**
* ALL 피드 조회.
*
Expand Down
29 changes: 27 additions & 2 deletions ...ain/java/issueissyu/backend/domain/community/service/query/CommunityQueryServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ public class CommunityQueryServiceImpl implements CommunityQueryService {
CommunityType.CARDNEWS
);

private static final List<CommunityType> CARDNEWS_FEED_SOURCE_TYPES = List.of(
CommunityType.POLICY,
CommunityType.CONTEST
);

// HOT 인기 점수 계산용
private static final int HOT_DAYS = 7;
// 홈에서 사용
Expand Down Expand Up @@ -149,6 +154,26 @@ public CommunityCursorPageResDTO getCommunityFeed(
List<Community> pageItems = hasNext ? communities.subList(0, size) : communities;

List<CommunityFeedItemResDTO> content = toFeedItems(pageItems);
if (tab == CommunityTab.CARDNEWS) {
content = content.stream()
.map(item -> new CommunityFeedItemResDTO(
CommunityType.CARDNEWS,
item.communityId(),
item.pinId(),
item.title(),
item.content(),
item.thumbnailUrl(),
item.writerNickname(),
item.writerProfileUrl(),
item.detailAddress(),
item.viewCount(),
item.likeCount(),
item.discount(),
item.eventStartTime(),
item.eventEndTime()
))
.toList();
}
Comment on lines +157 to +176

@gemini-code-assist gemini-code-assist Bot Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

CommunityFeedItemResDTO 객체의 모든 필드를 수동으로 복사하여 CommunityType.CARDNEWS로 kind만 변경하는 방식은 유지보수 관점에서 취약합니다. 향후 CommunityFeedItemResDTO에 필드가 추가되거나 삭제, 타입 변경이 일어날 경우 이 부분의 생성자 호출 코드도 함께 수정해야 하므로 에러가 발생하기 쉽습니다.

이를 개선하기 위해 CommunityFeedItemResDTO 레코드 내부에 특정 필드만 변경하여 새로운 인스턴스를 반환하는 withKind와 같은 메서드를 추가하는 것을 권장합니다.

추천 개선 방향:

  1. CommunityFeedItemResDTO 레코드에 아래와 같은 메서드를 추가합니다:
public CommunityFeedItemResDTO withKind(CommunityType newKind) {
    return new CommunityFeedItemResDTO(
            newKind,
            this.communityId,
            this.pinId,
            this.title,
            this.content,
            this.thumbnailUrl,
            this.writerNickname,
            this.writerProfileUrl,
            this.detailAddress,
            this.viewCount,
            this.likeCount,
            this.discount,
            this.eventStartTime,
            this.eventEndTime
    );
}
  1. 서비스 레이어에서는 제공된 코드 제안과 같이 간결하게 처리할 수 있습니다.
        if (tab == CommunityTab.CARDNEWS) {
            content = content.stream()
                    .map(item -> item.withKind(CommunityType.CARDNEWS))
                    .toList();
        }


String nextCursor = hasNext
? CursorKey.from(pageItems.get(pageItems.size() - 1)).encode()
Expand Down Expand Up @@ -272,8 +297,8 @@ private List<Community> fetchCommunities(CommunityTab tab, Long locationId, Curs
limit
);

case CARDNEWS -> communityRepository.findFeedByType(
CommunityType.CARDNEWS,
case CARDNEWS -> communityRepository.findCardnewsFeedByTypesWithImages(
CARDNEWS_FEED_SOURCE_TYPES,
cursorKey.createdAt(),
cursorKey.communityId(),
limit
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/issueissyu/backend/global/config/SwaggerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public OpenAPI openAPI() {
.description("IssueIssyu Local Server");

Server httpServer = new Server()
.url("http://issueissyu-backend-prod-env.eba-x2fpm3aq.ap-northeast-2.elasticbeanstalk.com")
.url("https://spring.issueissyu.cloud")
.description("IssueIssyu Prod Server");


Expand Down
Loading