fix: 민원 생성 응답을 직접 구성해 lazy loading 위험 제거#134
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the create_petition_for_issue_pin method in ComplaintPetitionService to directly instantiate ComplaintPetitionApplyResponse instead of using model_validate on a dumped model, and adds a null check for petition.generated_on in _to_review_item. Feedback highlights a potential MissingGreenlet exception when accessing location_department.department in an async SQLAlchemy environment, suggesting the use of the already available local variable department_name instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the create_petition_for_issue_pin method in ComplaintPetitionService.py to directly instantiate and return a ComplaintPetitionApplyResponse object instead of converting it through a review item first. Additionally, it adds a null check for petition.generated_on in _to_review_item to prevent potential errors when calling .isoformat(). There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
fix: 민원 생성 응답을 직접 구성해 lazy loading 위험 제거