Skip to content

fix: 민원 생성 응답을 직접 구성해 lazy loading 위험 제거#134

Merged
selnem merged 2 commits into
developfrom
hotfix/complaint-lazy-loding
Jun 16, 2026
Merged

fix: 민원 생성 응답을 직접 구성해 lazy loading 위험 제거#134
selnem merged 2 commits into
developfrom
hotfix/complaint-lazy-loding

Conversation

@selnem

@selnem selnem commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

fix: 민원 생성 응답을 직접 구성해 lazy loading 위험 제거

@selnem selnem self-assigned this Jun 16, 2026
@selnem selnem added the 🐞 bug 버그 수정 label Jun 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the create_petition_for_issue_pin method in ComplaintPetitionService to directly instantiate ComplaintPetitionApplyResponse instead of using model_validate on a dumped model, and adds a null check for petition.generated_on in _to_review_item. Feedback highlights a potential MissingGreenlet exception when accessing location_department.department in an async SQLAlchemy environment, suggesting the use of the already available local variable department_name instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread app/services/ComplaintPetitionService.py Outdated
@selnem

selnem commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the create_petition_for_issue_pin method in ComplaintPetitionService.py to directly instantiate and return a ComplaintPetitionApplyResponse object instead of converting it through a review item first. Additionally, it adds a null check for petition.generated_on in _to_review_item to prevent potential errors when calling .isoformat(). There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@selnem selnem merged commit e843746 into develop Jun 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant