[IP-518]: reference fields#585
Draft
nielsdrost7 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ae191c5 to
32e8528
Compare
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invoices and quotes had no fields for the client's own PO number, work order reference, or similar external identifiers.
Migrations:
2026_06_14_000001_add_reference_fields_to_invoices_table.php— addsclient_reference(varchar, nullable) andwork_order(varchar, nullable) afterinvoice_number2026_06_14_000001_add_reference_fields_to_quotes_table.php— same columns afterquote_numberForm schemas:
InvoiceForm.php— two newTextInputfields in the Details sectionQuoteForm.php— two newTextInputfields in the details gridTranslations (
resources/lang/en/ip.php):Scope note: issue #518 also asks for a Client Number field on the Clients module and an Agreement field on Quotes/Invoices — neither is in this diff. This PR delivers the
client_reference+work_orderslice only; #518 is attached below as a follow-up so the remaining scope stays visible (reopen it if the merge auto-closes it).Closes
(none in full — #518 is only partially addressed by this PR, see Follow-up issues)
Follow-up issues (not resolved here — reopen if auto-closed on merge)
Closes #518 — partially delivered:
client_reference+work_orderon Quotes/Invoices are in this PR; the Client-Number-on-Clients and Agreement-field scope is still openCloses #590 — Show client reference & work order as list-table columns (fields exist on model/form but not on the Invoices/Quotes list tables)
Closes #591 — Include client reference & work order fields in PDF template output (not yet rendered in generated PDFs)
Related: #546 — add
client_reference/work_orderto full-text search once the global search bar exists (tracked there, not here)Test plan
php artisan test --filter=ReferenceFieldsTest(Invoices and Quotes)