Skip to content

[IP-221]: client detail view#577

Draft
nielsdrost7 wants to merge 1 commit into
InvoicePlane:developfrom
underdogg-forks:feature/221-client-detail-view
Draft

[IP-221]: client detail view#577
nielsdrost7 wants to merge 1 commit into
InvoicePlane:developfrom
underdogg-forks:feature/221-client-detail-view

Conversation

@nielsdrost7

@nielsdrost7 nielsdrost7 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

What was missing

Clients had no detail/view page. The list was the only entry point, with only Edit and Delete actions.

Changes

ViewRelation page (Pages/ViewRelation.php)

Infolist on RelationResource

9-field client summary in a 3-column grid:
company_name, trading_name, relation_number, relation_type (badge), relation_status (badge), registered_at, coc_number, vat_number, currency_code

Five RelationManagers (tabs)

Manager Relationship Columns Extra
InvoicesRelationManager invoices (customer_id) number, status, dates, total Create Invoice header action
QuotesRelationManager quotes (prospect_id) number, status, dates, total Create Quote header action
ExpensesRelationManager expenses (vendor_id) number, date, description, amount
TasksRelationManager tasks (customer_id) number, name, status, due, price
ProjectsRelationManager projects (customer_id) number, name, status, start, end

All relationships were already defined on the Relation model — no model changes needed.

RelationsTable

Restored dependency

Closes

Closes #221 — Client detail — tabs for invoices, quotes, expenses and files
Closes #217 — Create a quote when viewing a specific client
Closes #218 — Create an invoice when viewing a specific client
Closes #191 — Create a quote for a specific client from the client list
Closes #192 — Create an invoice for a specific client from the client list
Closes #219 — Edit a client from the client detail view
Closes #220 — Hide delete button when client has invoices
Closes #29 — Client list — implement row action options

Follow-up issues

None — no stubs or unimplemented markers in this diff.

Test plan

  • RelationListRowActionsTest (5 tests) — action visibility, delete guard, both prefills
  • ViewRelationTest — viewing a relation, tabs render, header actions work
  • Delete behavior with and without linked records

@InvoicePlane InvoicePlane deleted a comment from coderabbitai Bot Jul 3, 2026
@InvoicePlane InvoicePlane deleted a comment from coderabbitai Bot Jul 4, 2026
@nielsdrost7 nielsdrost7 self-assigned this Jul 4, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@nielsdrost7 nielsdrost7 force-pushed the feature/221-client-detail-view branch from ff0253f to a2724e6 Compare July 4, 2026 12:23
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 223d1254-4166-4e27-bc41-ca76879d3994

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment