Skip to content

[IP-11]: company dashboard redirect#574

Draft
nielsdrost7 wants to merge 1 commit into
InvoicePlane:developfrom
underdogg-forks:claude/default-company-dashboard-redirect-wxfk3i
Draft

[IP-11]: company dashboard redirect#574
nielsdrost7 wants to merge 1 commit into
InvoicePlane:developfrom
underdogg-forks:claude/default-company-dashboard-redirect-wxfk3i

Conversation

@nielsdrost7

@nielsdrost7 nielsdrost7 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

After authentication, both elevated and regular users are now sent to the ivplv2 company dashboard (Modules/Core/Filament/Responses/LoginResponse.php). For elevated users the ivplv2 company is looked up globally by search_code; for regular users it is preferred from their attached companies. Both paths fall back gracefully (oldest / first company) when ivplv2 is absent.

Six PHPUnit tests in Modules/Core/Tests/Feature/LoginRedirectTest.php cover the redirect behaviour across role types and company attachment scenarios (elevated/regular × present/absent/multi-company).

Note: earlier versions of this PR body also referenced #138 (company switcher) — that is a separate feature with zero code in this diff, fully implemented in PR #583. Reference removed to avoid a double-close race.

Closes

Closes #11 — login no longer misroutes; elevated and regular users land on the ivplv2 company dashboard with a documented fallback

Follow-up issues

None.

Test plan

  • php artisan test --filter=LoginRedirectTest — all 6 scenarios pass
  • Manually log in as an elevated user and a regular (client) user, confirm both land on /ivplv2/dashboard

@InvoicePlane InvoicePlane deleted a comment from coderabbitai Bot Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c9091ae1-cb2b-4d9c-bab1-d22a840ea36a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nielsdrost7 nielsdrost7 changed the title Claude/default company dashboard redirect wxfk3i [IP-11]: company dashboard redirect Jul 4, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@nielsdrost7 nielsdrost7 force-pushed the claude/default-company-dashboard-redirect-wxfk3i branch from 0b5fcaf to 1f40cd2 Compare July 4, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Core]: Login screen

1 participant