[IP-11]: company dashboard redirect#574
Draft
nielsdrost7 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
0b5fcaf to
1f40cd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After authentication, both elevated and regular users are now sent to the ivplv2 company dashboard (
Modules/Core/Filament/Responses/LoginResponse.php). For elevated users the ivplv2 company is looked up globally bysearch_code; for regular users it is preferred from their attached companies. Both paths fall back gracefully (oldest / first company) when ivplv2 is absent.Six PHPUnit tests in
Modules/Core/Tests/Feature/LoginRedirectTest.phpcover the redirect behaviour across role types and company attachment scenarios (elevated/regular × present/absent/multi-company).Note: earlier versions of this PR body also referenced #138 (company switcher) — that is a separate feature with zero code in this diff, fully implemented in PR #583. Reference removed to avoid a double-close race.
Closes
Closes #11 — login no longer misroutes; elevated and regular users land on the ivplv2 company dashboard with a documented fallback
Follow-up issues
None.
Test plan
php artisan test --filter=LoginRedirectTest— all 6 scenarios pass/ivplv2/dashboard