[IP-160]: convert a quote to a draft invoice#573
Closed
nielsdrost7 wants to merge 2 commits into
Closed
Conversation
QuoteService::convertQuoteToInvoice() copies the client, items, totals, and summary fields onto a new unnumbered draft invoice inside a transaction, then marks the quote Converted (new QuoteStatus case). The convert_to_invoice table action is wired to the service, requires confirmation, and hides once a quote is converted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #160 (kept open per workflow — PRs stay draft).
What
QuoteService::convertQuoteToInvoice(Quote): Invoice— inside a transaction: copiesprospect_id → customer_id, all quote items (name, qty, price, discounts, both tax rates, task link), the discount/tax/total summary, andsummary/terms/footeronto a new draft invoice; then sets the quote to the newQuoteStatus::CONVERTEDcase.Deviation from the SMART plan: no redirect to
EditInvoice— that page only exists on PR #544's branch. Trivial follow-up once #544 lands.Tests
QuoteConversionTest— 3 tests: full conversion (items, totals, status), double-conversion rejection, action visibility.Note: upstream CI fails at job startup on every branch — validated locally; Quotes+Invoices suites match the develop baseline exactly plus the new passing tests.
🤖 Generated with Claude Code