[IP-268]: bill project tasks to a draft invoice#572
Closed
nielsdrost7 wants to merge 2 commits into
Closed
Conversation
ProjectBillingService::billTasks() creates one invoice item per selected task (name, description, price, tax rate; quantity 1) on the client's existing draft invoice, or a new unnumbered draft when none exists. Only completed tasks not already linked to an invoice item qualify. The Bill Tasks row action on the projects list opens a checkbox list of billable tasks and reports success or the guard message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #268 (kept open per workflow — PRs stay draft).
What
ProjectBillingService::billTasks(Project, array $taskIds): Invoice— creates one invoice item per selected task (item name = task name, quantity 1, price =task_price, task's tax rate,task_idlink). Appends to the client's existing draft invoice when one exists, otherwise creates a new draft with a null invoice number (numbering is assigned when the invoice leaves draft — consistent with the duplicate-prevention observer on PR [IP-513]: duplicate-number prevention via Observers #540, which allows multiple nulls for drafts).invoice_items.task_id) qualify — double billing is impossible.create-invoices) opens a checkbox list of billable tasks; guard failures surface as a notification.Deviation from the SMART plan: no redirect to
EditInvoice— that page only exists on PR #544's branch, not on develop yet. Trivial to add once #544 lands.Tests
ProjectBillingTest— 5 tests: new draft creation, append-to-existing-draft, double-billing rejection, non-completed rejection, and modal option filtering.Note: upstream CI fails at job startup on every branch (no runner assigned) — validated locally; the 24 pre-existing Projects failures (permission-seeding 403s) are unchanged.
🤖 Generated with Claude Code