[IP-568]: correction of dark mode contrast in various locations#570
Draft
nielsdrost7 wants to merge 1 commit into
Draft
[IP-568]: correction of dark mode contrast in various locations#570nielsdrost7 wants to merge 1 commit into
nielsdrost7 wants to merge 1 commit into
Conversation
Collaborator
Author
|
@coderabbitai summary |
Contributor
📝 WalkthroughWalkthroughThe company Filament themes remap gray tokens and tighten sidebar active, hover, and trigger styling across the blue, nord, orange, and reddit variants. The Vite setup also splits development and production build commands and enables minification only in production. ChangesSidebar theme overrides
Build mode split
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
a15e742 to
d8d2792
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filament applies
--gray-100to.fi-sidebar-item.fi-active > .fi-sidebar-item-btn(the child<a>element), not the<li>container. All custom themes were only overriding the container, leaving the near-white button visible over dark/colored sidebars and making white text unreadable. Extended each theme'sfi-activeblock to also target> .fi-sidebar-item-btn,> .fi-icon, and> .fi-sidebar-item-labelacross all five company themes (invoiceplane.css,invoiceplane-blue.css,nord.css,orange.css,reddit.css).Also: gray token remaps per theme, hover/focus/trigger text fixes for dropdown triggers, notification buttons, and user/tenant menus; Vite build now splits dev vs. production modes (minification only in production).
Closes
Closes #568 — dark-mode/active-sidebar-item contrast fixed across all company themes
Follow-up issues
None.
Test plan
npm run build(production) still minifies; dev build unaffected