Skip to content

Comment out test/lint steps in composer-update workflow#293

Merged
nielsdrost7 merged 2 commits into
developfrom
copilot/sub-pr-282
Dec 29, 2025
Merged

Comment out test/lint steps in composer-update workflow#293
nielsdrost7 merged 2 commits into
developfrom
copilot/sub-pr-282

Conversation

Copilot AI commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

Per review feedback on #282, test/lint tools need to be isolated to their dedicated workflows until stable. The composer-update workflow was running phpunit, phpstan, and pint on every dependency update.

Changes

  • Commented out test execution in .github/workflows/composer-update.yml

    • Changed to --group=smoke for future use
    • Disabled lines 81-85
  • Commented out phpstan and pint steps

    • Disabled lines 87-88 (static analysis)
    • Disabled lines 90-91 (code formatting)
  • Updated PR template

    • Marked checks as disabled in generated PR body

Workflow Scope

Test/lint tools now only run in dedicated manual workflows:

  • phpunit.yml - Tests
  • phpstan.yml - Static analysis
  • pint.yml - Code formatting

Other workflows (quickstart.yml, release.yml, yarn-update.yml, crowdin-sync.yml) remain unchanged.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Dec 29, 2025
@coderabbitai

coderabbitai Bot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Copilot AI changed the title [WIP] Update GitHub Actions for testing and linting setup Comment out test/lint steps in composer-update workflow Dec 29, 2025
Copilot AI requested a review from nielsdrost7 December 29, 2025 16:59
@nielsdrost7 nielsdrost7 requested a review from Copilot December 29, 2025 17:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables test and lint steps in the automated Composer dependency update workflow, isolating these quality checks to their dedicated manual workflows per feedback from #282. The workflow will continue to run security audits and create PRs for dependency updates, but without executing tests or code quality checks.

Key Changes:

  • Commented out PHPUnit test execution, replacing --testsuite=Unit with --group=smoke for future use
  • Commented out PHPStan static analysis step
  • Commented out Laravel Pint code formatting step
  • Updated PR template to reflect disabled checks with strikethrough formatting

@nielsdrost7 nielsdrost7 marked this pull request as ready for review December 29, 2025 17:16
@nielsdrost7 nielsdrost7 merged commit 025ccad into develop Dec 29, 2025
7 checks passed
@nielsdrost7 nielsdrost7 deleted the copilot/sub-pr-282 branch December 29, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants