Fix code review issues: factory calls, debug statements, and type hints#287
Merged
Conversation
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Merge development branch into master
Fix code review issues: factory calls, debug statements, and type hints
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 8 code review findings from PR #282 covering incorrect factory usage, debug statements left in production code, missing test attributes, and type safety improvements.
Factory Fixes
Product::factory()toTaxRate::factory()when creating tax ratesdd('die early')statements with proper factory fallbacks forProduct,ProductUnit, andTaxRatecreationTest Consistency
#[Test]and#[Group('crud')]attributes toit_deletes_a_usermethodCode Quality
mb_rtrim()tortrim()for ASCII character trimming (better performance)?Usertype hint to$superAdminproperty💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.