This repository was archived by the owner on Dec 9, 2023. It is now read-only.
Added possibility to define Templates with arguments#62
Open
eightyfive wants to merge 2 commits intoIntervention:masterfrom
eightyfive:master
Open
Added possibility to define Templates with arguments#62eightyfive wants to merge 2 commits intoIntervention:masterfrom eightyfive:master
eightyfive wants to merge 2 commits intoIntervention:masterfrom
eightyfive:master
Conversation
Author
|
Does it make sense? The problem I was facing is that I had to create a new Template for every different parameters combination of a given image transformation (which is exactly the problem of the documentation example: small, medium, large are all the same transformation). |
Author
|
Up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added what I believe is a simple yet very helpful trick. But I obviously may not see the entire picture.
That would fully resolve issues like this one:
Intervention/image#368
And would still hold the security argument:
Intervention/image#241
See basic example:
Would become:
And would allow easy customisation.
What are your thoughts?