Skip to content

Synchronize keys and handle missing values in dist_utils #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jimmy-Mendez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Synchronize keys and handle missing values in dist_utils #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions engine/misc/dist_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,18 +187,31 @@ def reduce_dict(data, avg=True):
return data

with torch.no_grad():
keys, values = [], []
for k in sorted(data.keys()):
keys.append(k)
values.append(data[k])
# Synchronize keys across all ranks to handle cases where some ranks
# have different loss keys (e.g., due to empty batches)
local_keys = set(data.keys())
all_keys_list = [None] * world_size
torch.distributed.all_gather_object(all_keys_list, local_keys)
all_keys = sorted(set().union(*all_keys_list))

# Get device from data values
device = next(iter(data.values())).device if data else torch.device("cuda")

# Build values tensor with zeros for missing keys
values = []
for k in all_keys:
if k in data:
values.append(data[k])
else:
values.append(torch.tensor(0.0, device=device))

values = torch.stack(values, dim=0)
torch.distributed.all_reduce(values)

if avg is True:
values /= world_size

return {k: v for k, v in zip(keys, values)}
return {k: v for k, v in zip(all_keys, values)}


def all_gather(data):
Expand Down