Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
Looks clean. Let me test |
Author
|
To run the test cd in the test directory and run npm run test:unit |
Owner
|
i am extremely sorry, I didn't opened my system today |
Owner
|
@JP-sDEV I am working on some patches i will merge it after making some changes |
Owner
|
Many tests are failing almost every @JP-sDEV But it shouldn't all expected tests are not as per format. HTTP format is not like just simple text. Make it at least pass 80% |
Author
|
@IntegerAlex sure, I will revise the tests to match the project specs. What content-types are supported? Also is |
Owner
|
Okay i will fix Query parser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testdirectory to include unit tests - allows for flexibility (e.g. include integration tests in the future)npm run unit:testto run all unit testslib/utils.jsSuggestion: combine
test/package.jsonwithpackage.json(i.e. found in the root), to simplify the scripts and requirements. This also allows for jest to analyze test coverage.