Mentor workspace: Закрепление преподавателя за группами#670
Open
semrosin wants to merge 41 commits into
Open
Conversation
DedSec256
reviewed
May 16, 2026
Comment on lines
+90
to
+94
| await props.onCreateNewGroup?.({ | ||
| id: groupId, | ||
| name: formState.name.trim(), | ||
| studentsIds: formState.memberIds, | ||
| }); |
Contributor
There was a problem hiding this comment.
точно ли нам нужен этот метод?
Comment on lines
+132
to
+143
| const courseData = await ApiSingleton.coursesApi.coursesGetAllCourseData(courseId) | ||
| const [courseData, mentorWorkspace] = await Promise.all([ | ||
| ApiSingleton.coursesApi.coursesGetAllCourseData(courseId), | ||
| isNewHomework | ||
| ? ApiSingleton.coursesApi.coursesGetMentorWorkspace(courseId, props.mentorId) | ||
| .catch(() => undefined) | ||
| : Promise.resolve(undefined) | ||
| ]); |
Contributor
There was a problem hiding this comment.
давай перенесем логику работы с фильтрами на бекенд, фронтенд не должен знать про воркспейс
semrosin
force-pushed
the
assign-lecturer-to-group-feature
branch
from
b4a04d3 to
0c9e148
Compare
…/InteIIigeNET/HwProj-2.0.1 into assign-lecturer-to-group-feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Данный PR добавляет функциональность закрепления преподавателя за группами (добавления групп в фильтр):
Группы и домашние задания теперь автоматически (при необходимости) добавляются в воркспейс преподавателя после создания
При получении MentorWorkspace поля, не выбранные явно преподавателем, возвращаются пустыми, а не содержащими всю информацию о курсе как раньше