Decimal number separator fix #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set globally in constructor
Contributor
There was a problem hiding this comment.
Indentation here (spaces) does not match the surrounding code (tabs). Please use tabs so the formatting is consistent.
Using tabs instead of spaces. Added more info about issue fix in the comment.
Contributor
There was a problem hiding this comment.
You can't change a thread's culture from within the SDK, there are two reasons for that:
- You may affect the host application, which may have set their own culture
- The SDK runs in multiple threads and you are changing the culture for only one of them
Please use the correct Culture explicitly at the place where the string gets formatted. You want to use CultureInfo.InvariantCulture as the culture as it already has . as the decimal separator. I'm not sure about thousands separator though, please check that.
added 3 commits
November 18, 2015 14:22
Invariant culture set in double converting to string in miniJSON due to system locale bug where “,” decimal separator was used instead of “.”
Its questionable if its ok to call it in method everytime
Decimal conversion using Invariant Culture with R parameter that should be enough to fix problem with “,” in decimals in some cultures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set globally in constructor