Insert table to ppt

[marrip]

hey @xiaoliz0 ,

I have started on the refactoring. I have introduced pandas and moved the part that checks the column headers and moves the columns around in an extra function. I am keeping additional headers in the table but I place them to the far right so that they will get ignored with the current setup but I think we should discuss if they should be handled differently. I will continue with the refactoring but please feel free to give feedback and suggestions in the meantime.

[xiaoliz0]

Hi Martin,
Thanks for the contribution to the new function! I am not very confident to review the details with the codes. I did some testings in our environment with your new codes. There is one issue that one column "AF_tumor_DNA" in the tables in report showing wrong format. It should be float I think. This number should be displayed to three decimal places, but now there are many many numbers.

[marrip]

Hi Martin, Thanks for the contribution to the new function! I am not very confident to review the details with the codes. I did some testings in our environment with your new codes. There is one issue that one column "AF_tumor_DNA" in the tables in report showing wrong format. It should be float I think. This number should be displayed to three decimal places, but now there are many many numbers.

Hey Xiaoli, thanks for your feedback! I have added another small function that can basically convert any column into the 2 decimal format that you want. I applied it for AF_tumor_DNA which hopefully fixes the issue you were seeing 🤞

[xiaoliz0]

Hi Martin, Thanks for the contribution to the new function! I am not very confident to review the details with the codes. I did some testings in our environment with your new codes. There is one issue that one column "AF_tumor_DNA" in the tables in report showing wrong format. It should be float I think. This number should be displayed to three decimal places, but now there are many many numbers.

Hey Xiaoli, thanks for your feedback! I have added another small function that can basically convert any column into the 2 decimal format that you want. I applied it for AF_tumor_DNA which hopefully fixes the issue you were seeing 🤞

Hi Martin, I did a quick testing today and there is some errors related.

[marrip]

Hi Martin, Thanks for the contribution to the new function! I am not very confident to review the details with the codes. I did some testings in our environment with your new codes. There is one issue that one column "AF_tumor_DNA" in the tables in report showing wrong format. It should be float I think. This number should be displayed to three decimal places, but now there are many many numbers.

Hey Xiaoli, thanks for your feedback! I have added another small function that can basically convert any column into the 2 decimal format that you want. I applied it for AF_tumor_DNA which hopefully fixes the issue you were seeing 🤞

Hi Martin, I did a quick testing today and there is some errors related.

I think I know why this happens. I have introduced a fix. Instead of assuming float it will convert string to float and then do the decimal rounding

[marrip]

I have refactored some more. I am quite happy with the result, we are actually testing smaller parts now and now that they work on their own. Not sure if we should maybe add a test for the whole function insert_table_to_ppt. You could give me your use case and we test that it produces a certain output every time.