Conversation
|
I didn't find time to look through this yet. Is it super urgent or can we try fix the other PR first? |
This currently only affects OUS. It is urgent for us since it is a bug. But I have fixed it locally in our side. So I think we could deal it before next newer version of PRONTO published. :) |
|
yes, I thought we do it directly after we have fixed the other PR 👍 |
| gender = str(sheet_material.cell_value(r+2,c)) | ||
| if(gender != "" and gender != "X"): | ||
| ipd_gender = gender[0] |
There was a problem hiding this comment.
what exactly is happening here, we check if the column is Gender and then we extract the value from 2 rows down. We check if the value is not empty string and not Xand only then we assign it to ipd_gender. But I don't get why gender at index 0 (is gender a list?). Also it seems that ipd_gender is already empty string why check if gender is empty string if this would actually not change anything?
| tf11.paragraphs[0].font.size = Pt(10) | ||
| tf11.paragraphs[0].alignment = PP_ALIGN.LEFT | ||
| gender_age = gender + '/' + age + 'y' | ||
| gender_age = ipd_gender + '/' + age + 'y' |
There was a problem hiding this comment.
| gender_age = ipd_gender + '/' + age + 'y' | |
| gender_age = "{}/{}y'.format(ipd_gender, age) |
marrip
left a comment
marrip
left a comment
There was a problem hiding this comment.
I have a question about how you handle gender assignment and would suggest to use a format string. Other than that, I think this looks good 👍
2 participants
Bug fix: PRONTO will crash when the "Gender" information is missing in MTF file.