dynamic pyproject version and make release target#7
Merged
Merged
Conversation
- pyproject.toml: switch to dynamic = ["version"] so maturin reads
the version from Cargo.toml at build time, eliminating the drift
that left pkpython pinned at 0.1.0 on PyPI while Cargo advanced.
- Makefile: add `make version` (prints Cargo.toml version) and
`make release` (preflights clean tree, missing CHANGELOG entry,
duplicate tag; then annotate-tags HEAD and pushes to origin to
fire publish.yml).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release tooling and dynamic pyproject version" --body "$(cat <<'EOF'
Summary
pyproject.toml: switch todynamic = ["version"]so the Python distribution version tracksCargo.toml. Verified with a localmaturin build --releaseproducingpkpython-0.0.54-*.whl.Makefile: addmake versionandmake releasetargets. Thereleasetarget is the trigger for.github/workflows/publish.yml.Test plan
make versionprints0.0.54make buildsucceeds; wheel name carries0.0.54make releasepreflights correctly (clean tree, CHANGELOG entry present, tag not yet existing)