Handle empty fish_key_bindings in fish 4.3 (fixes #620, #622)#626
Open
sstieger wants to merge 1 commit intoIlanCosman:mainfrom
Open
Handle empty fish_key_bindings in fish 4.3 (fixes #620, #622)#626sstieger wants to merge 1 commit intoIlanCosman:mainfrom
sstieger wants to merge 1 commit intoIlanCosman:mainfrom
Conversation
…nCosman#622) Fish 4.3 seems to leave $fish_key_bindings empty by default, leading the check for default bindings in _tide_item_character to fail, and causing tide to render the vi-mode icons instead of the standard prompt character.
sstieger
force-pushed
the
fix/character-empty-fish-key-bindings
branch
from
b414be3 to
0dcace8
Compare
Author
|
Oh, missed #619 when creating this, since it wasn't mentioned in the two issues. |
|
It's probably a little pedantic, but doesn't this style of running test with && and || a little non-robust. Might it be better to make it a formal if/else thing? |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fish 4.3 seems to leave
$fish_key_bindingsempty by default, leading the check for default bindings in_tide_item_characterto fail, and causing tide to render the vi-mode icons instead of the standard prompt character.Description
Updated
_tide_item_characterto include a check for empty$fish_key_bindings.Closes #620.
Closes #622.
How Has This Been Tested
Checklist