Handle empty fish_key_bindings in fish 4.3 (fixes #624)#625
Open
sstieger wants to merge 1 commit intoIlanCosman:mainfrom
Open
Handle empty fish_key_bindings in fish 4.3 (fixes #624)#625sstieger wants to merge 1 commit intoIlanCosman:mainfrom
sstieger wants to merge 1 commit intoIlanCosman:mainfrom
Conversation
Fish 4.3 seems to leave $fish_key_bindings empty by default, causing a false positive in the vi_mode check.
sk-m
approved these changes
Jan 8, 2026
krobelus
reviewed
Jan 10, 2026
| @@ -1,5 +1,5 @@ | |||
| function _tide_item_vi_mode | |||
| test "$fish_key_bindings" != fish_default_key_bindings && switch $fish_bind_mode | |||
| test -n "$fish_key_bindings" && test "$fish_key_bindings" != fish_default_key_bindings && switch $fish_bind_mode | |||
There was a problem hiding this comment.
Fish 4.3 seems to leave $fish_key_bindings empty by default, causing a false positive in the vi_mode check.
yeah it's only set on the first fish_prompt or fish_read event now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fish 4.3 seems to leave
$fish_key_bindingsempty by default, causing a false positive in the vi_mode check.Description
Updated
_tide_item_vi_modeto explicitly check for non-empty$fish_key_bindingsfirst.Closes #624.
How Has This Been Tested
Checklist