Open
Conversation
|
It would also be nice if this handled co-located jj repos better instead of having both the |
Author
|
I haven't used pills so I haven't seen this, but will take a look at that and identifying colocation in ~1 week or so. The secondary ID (commit hash) would be sufficient for Git operations and colocation's an explicit-enough interaction I think it would make sense to exclude Git in that case 👍 |
|
from my debugging it has something to do with needing in fish_variables (to get any pills at all to work). But then the colors you get from |
|
What I ended up using is: |
fowles
reviewed
Nov 10, 2025
Comment on lines
+8
to
+17
| bookmarks.map(|x| if( | ||
| x.name().substr(0, 10).starts_with(x.name()), | ||
| x.name().substr(0, 10), | ||
| x.name().substr(0, 9) ++ "…") | ||
| ).join(" "), | ||
| tags.map(|x| if( | ||
| x.name().substr(0, 10).starts_with(x.name()), | ||
| x.name().substr(0, 10), | ||
| x.name().substr(0, 9) ++ "…") | ||
| ).join(" "), |
There was a problem hiding this comment.
Suggested change
| bookmarks.map(|x| if( | |
| x.name().substr(0, 10).starts_with(x.name()), | |
| x.name().substr(0, 10), | |
| x.name().substr(0, 9) ++ "…") | |
| ).join(" "), | |
| tags.map(|x| if( | |
| x.name().substr(0, 10).starts_with(x.name()), | |
| x.name().substr(0, 10), | |
| x.name().substr(0, 9) ++ "…") | |
| ).join(" "), | |
| bookmarks.map(|x| truncate_end(10, x.name(), "…")).join(" "), | |
| tags.map(|x| truncate_end(10, x.name(), "…")).join(" "), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds an item for jj based on their fish and Starship prompts.
Screenshots (if appropriate)
How Has This Been Tested
Checklist