Support WSL project terminals on Windows#293
Merged
Merged
Conversation
Why: - Native Windows terminal launch currently treats WSL UNC project paths as host Windows paths. - Opening a WSL project through \\wsl$ or \\wsl.localhost should start the embedded shell inside that distro and Linux cwd. Verified: - bun vitest run desktop/terminal/terminal-command.helpers.test.ts - bun x biome check desktop/terminal/terminal-command.helpers.ts desktop/terminal/terminal-process.ts desktop/terminal/terminal-command.helpers.test.ts - bun run typecheck:desktop - git diff --check (cherry picked from commit 7657ccc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wsl.exe --cdinstead of using UNC as the process cwdVerification
Cherry-picks the actual author WSL commit from #264 and drops the diverged history.