feat: add Custom Docker Labels support to App Store wizard (Fixes #1518)#259
Open
brianewman wants to merge 2 commits intoIceWhaleTech:mainfrom
Open
feat: add Custom Docker Labels support to App Store wizard (Fixes #1518)#259brianewman wants to merge 2 commits intoIceWhaleTech:mainfrom
brianewman wants to merge 2 commits intoIceWhaleTech:mainfrom
Conversation
Author
|
Closing this temporarily. I realized I targeted main instead of the correct development branch. I will open an issue to discuss the feature and find out the correct target branch before resubmitting. Thanks! |
Author
|
Upon further review, it appears it may be acceptable to submit this against main. I'm going to reopen it, but feel free to close it if I'm wrong. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What does this PR do?
This introduces frontend support for defining arbitrary Custom Docker Labels when creating or editing an application via the App Store's "Custom Install" wizard.
This UI submission is the frontend companion to the label parsing logic implemented in
CasaOS-AppManagementPR 213.Changes Made
Labelsarray input group to the ComposeConfig.vue template, styled identically to the Environment Variables wizard.labelsfrom an imported Docker Compose template and bind them to the reactivecomposeServicesItem.labelsstate.casaos,icon,host,com.docker.compose.*, etc.) from the user-facing UI, preventing accidental corruption of daemon-managed configuration parameters.Related Issues