catch media stream error, set canvas height/width from offsetHeight/width#3
Open
elmarti wants to merge 3 commits into
Open
catch media stream error, set canvas height/width from offsetHeight/width#3elmarti wants to merge 3 commits into
elmarti wants to merge 3 commits into
Conversation
Closed
Author
I messed up the actual commit
IagoLast
reviewed
Dec 8, 2016
| this._width = this._video.width; | ||
| this._height = this._video.height; | ||
| this._video = this._createVideoElement(videoSelector); | ||
| this._width = this._video.offsetWidth; |
Owner
There was a problem hiding this comment.
offsetWidth is only working on chrome, can you change this and use clientWidth instead? same for height
Author
There was a problem hiding this comment.
Hi, no problem, i'll update in a couple of hours
Author
|
Resolved and tested on Firefox and Chrome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with set height/width attributes and without