Refactor icon display logic for Windows and remove unnecessary text from menus

[ITx-prash]

Summary

• Removed ugly bracket icons ([BANK], [REG], etc.) from Windows interface
• Deleted "Made with <3" text from all menus
• Linux emoji icons preserved (🏦, 📝, 🔐)

Result

Cleaner, more professional Windows interface while maintaining Linux visual appeal.

Testing: ✅ Both platforms built and verified successfully

[Copilot]

Pull Request Overview

This PR refactors the icon display logic to provide cleaner Windows interface while preserving Linux emoji functionality. The changes remove complex Windows emoji detection and simplify the user experience by eliminating promotional text.

• Simplified Windows icon logic by removing emoji detection and bracket-style icons
• Removed "Made with <3" promotional text from all menu displays
• Fixed inconsistent exit icon usage in main function

Comments suppressed due to low confidence (1)

crow-bank-app/main.cpp:370

• [nitpick] The success message format "[SUCCESS]" is inconsistent with the existing "[OK]" format that was replaced. Consider using "[OK]" to maintain consistency with the existing codebase pattern.

        return "[SUCCESS]";

[Copilot]

This line will display an empty string on Windows since getIcon("exit") returns "" for Windows, resulting in inconsistent formatting. The original hardcoded symbol may have been intentional to ensure consistent display across platforms.

Suggested change

	cout << "\n" << getIcon("exit") << " Thank you for exploring SecureBank!\n";
	{
	std::string exitIcon = getIcon("exit");
	if (exitIcon.empty()) exitIcon = ">>";
	cout << "\n" << exitIcon << " Thank you for exploring SecureBank!\n";
	}