Skip to content

Swap auth to cognito - project access control from RDS#94

Open
alasdairwilson wants to merge 7 commits into
mainfrom
accounts
Open

Swap auth to cognito - project access control from RDS#94
alasdairwilson wants to merge 7 commits into
mainfrom
accounts

Conversation

@alasdairwilson
Copy link
Copy Markdown
Member

  • Added Cognito auth flow (login/callback/logout) and JWT validation.
  • Added DB-backed user lookup + allowed project lookup.
  • we cache this db return for a bit to prevent constant calls
  • Enforced access server-side in callbacks (client login state no longer trusted except for visual button state).
  • Refactored auth/access logic into dedicated modules.
  • Fixed direct URL project selection when access is controlled so URL is not overwritten on initial load.
  • Added token-exchange error handling.

Comment thread vertex/auth/routes.py Fixed
Comment thread vertex/descriptive_dashboard.py Fixed
Comment thread vertex/auth/routes.py Dismissed
@lithomson
Copy link
Copy Markdown
Collaborator

Nice to see the auth/access logic separated into dedicated modules — feels much easier to follow.
Caching the user lookup also seems like a sensible way to avoid repeated DB calls during auth/access checks.
Looks good overall to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants