Fixed issue where metadata would come with garbage#50
Open
Tjoms99 wants to merge 2 commits intoIRNAS:masterfrom
Open
Fixed issue where metadata would come with garbage#50Tjoms99 wants to merge 2 commits intoIRNAS:masterfrom
Tjoms99 wants to merge 2 commits intoIRNAS:masterfrom
Conversation
…2 session were not terminated properly due to garbage data coming along with the metadata. We now expect them and try to get metadata one more time, but this time without garbage from previous session
…ld also just work after connecting to a PPK2 via USB
Open
|
Thanks for the fix, it helped to figure out the way my test work! Good fix for me :) |
|
Also tested and it works for me! |
|
This is on 4.2.0 and 4.2.1 fw. |
|
works fine, thank you! |
Contributor
|
Works also on my side. @wlgrd is it possible to merge it into master? |
|
+1 Can we merge this? Running into the same issue. Is this project still actively maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigated the PR/issue discussed here #49.
Turns out not properly exiting a program running the PPK2 influences the next PPK2 session. Setting up the metadata the first time will throw an exception due to the garbage data (from the previous session) that comes a long with it. Physically turning the PPK2 on and off using the switch resolves this issue, but that’s inconvenient to do every time; So I’ve added a software fix here :)
To reproduce the issue and showcase the fix
Connect the PPK2 via USB
Open a terminal and run the example
This is where the
UnicodeDecodeErrorwould previously be triggered