Skip to content

Fix epochs schema to resolve double nesting of sdpi:Epoch element. #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulMartinsen wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −11
Open

Fix epochs schema to resolve double nesting of sdpi:Epoch element. #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88d3c0d
Fix epochs schema to resolve double nesting of `sdpi:Epoch` element.
PaulMartinsen Mar 24, 2026
6eabb0d
Merge branch 'master' into 520-example-13-does-not-comply-to-the-sche…
JavierEspina Mar 31, 2026
1271e9e
Changed version attribute to optional with a default value of 0, the …
PaulMartinsen Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Each section shall contain a list of action items of the following format: `<bri

- Corrected three erroneous context-free codes in Table 3:8.3.2.10.2-1 ([#505](https://github.com/IHE/DEV.SDPi/issues/505))
- Clarified referenced standards sections in 2:A and removed ISO prefix from IEEE/ISO standards for referential consistency ([#390](https://github.com/IHE/DEV.SDPi/issues/390))
- Fixed TimeStampVersion.xsd to resolve double nesting of sdpi:Epoch element ([#520](https://github.com/IHE/DEV.SDPi/issues/520)).
- Correction of regular expression for xsd:duration restriction ([#516](https://github.com/IHE/DEV.SDPi/issues/516))

### Editorial Fixes
Expand Down
20 changes: 9 additions & 11 deletions sources/extension-models/timestamp/TimeStampVersion.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,24 +48,14 @@
<!---->
<!---->
<!--Epochs-->
<xsd:element name="Epochs">
<xsd:element name="Epochs" type="sdpi:EpochsType">
<xsd:annotation>
<xsd:documentation>
An extension to version epochs arising from non-slewing time adjustments.

This extension can be attached to the pm:ClockState/ext:Extension element.
</xsd:documentation>
</xsd:annotation>
<xsd:complexType>
<xsd:sequence>
<xsd:element name="Epoch" type="sdpi:EpochsType" minOccurs="0" maxOccurs="unbounded" />
</xsd:sequence>
<xsd:attribute name="Version" type="sdpi:EpochVersion" use="required">
<xsd:annotation>
<xsd:documentation>Current epoch version. Implied value is 0.</xsd:documentation>
</xsd:annotation>
</xsd:attribute>
</xsd:complexType>
</xsd:element>
<xsd:complexType name="EpochsType">
<xsd:annotation>
Expand All @@ -77,6 +67,14 @@
minOccurs="0"
maxOccurs="unbounded" />
</xsd:sequence>
<xsd:attribute name="Version"
default="0"
type="sdpi:EpochVersion"
use="optional">
<xsd:annotation>
<xsd:documentation>Current epoch version. Implied value is 0.</xsd:documentation>
Copy link
Copy Markdown
Collaborator

@d-gregorczyk d-gregorczyk Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just bumped into this. A required field cannot have an implied value. You would need to make the attribute optional and set a default="0".

Copy link
Copy Markdown
Collaborator Author

@PaulMartinsen PaulMartinsen Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David. Updated now.

</xsd:annotation>
</xsd:attribute>
</xsd:complexType>
<xsd:complexType name="EpochType">
<xsd:annotation>
Expand Down
Loading