Skip to content

chore(example): example slurm script demonstrating slurm airfoil data…#234

Open
fgvangessel-umd wants to merge 1 commit intomainfrom
slurm-airfoil-example
Open

chore(example): example slurm script demonstrating slurm airfoil data…#234
fgvangessel-umd wants to merge 1 commit intomainfrom
slurm-airfoil-example

Conversation

@fgvangessel-umd
Copy link
Contributor

Description

Created example usage of slurm dataset generate via a slurm script placed in new directory slurm_tutorial.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have run ruff check . and ruff format
  • I have run mypy .

Reviewer Checklist:

  • The content of this PR brings value to the community. It is not too specific to a particular use case.
  • The tests and checks pass (linting, formatting, type checking). For a new problem, double check the github actions workflow to ensure the problem is being tested.
  • The documentation is updated.
  • The code is understandable and commented. No large code blocks are left unexplained, no huge file. Can I read and understand the code easily?
  • There is no merge conflict.
  • The changes are not breaking the existing results (datasets, training curves, etc.). If they do, is there a good reason for it? And is the associated problem version bumped?
  • For a new problem, has the dataset been generated with our slurm script so we can re-generate it if needed? (This also ensures that the problem is running on the HPC.)
  • For bugfixes, it is a robust fix and not a hacky workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants