Skip to content

refactor: update TrainingOverviewPage and TrainingNavigation for impr… #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TryOmar wants to merge 2 commits into
base: development
Choose a base branch
from
Open

refactor: update TrainingOverviewPage and TrainingNavigation for impr… #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09c692d
refactor: update TrainingOverviewPage and TrainingNavigation for impr…
TryOmar Jul 1, 2025
1a6cd36
refactor: remove async from TrainingNavigation component for cleaner …
TryOmar Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 22 additions & 46 deletions src/app/protected/trainings/[trainingId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use client";
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from "@/components/ui/card";
import { Badge } from "@/components/ui/badge";
import { BookOpen, Users, Trophy, Bell } from "lucide-react";
import { BookOpen, Users, Trophy } from "lucide-react";
import { TypographyH1 } from "@/components/ui/typography";
import { useTrainingContext } from "@/providers/training";
import { useParams } from "next/navigation";
Expand Down Expand Up @@ -73,58 +73,34 @@ export default function TrainingOverviewPage() {
</Card>
</div>

<div className="grid gap-6 md:grid-cols-2">
<Card>
<CardHeader>
<CardTitle className="flex items-center gap-2">
<Bell className="h-5 w-5" />
Announcements
</CardTitle>
<CardDescription>
Important updates and news about this training
</CardDescription>
</CardHeader>
<CardContent>
<div className="text-center py-8">
<Bell className="h-12 w-12 text-muted-foreground mx-auto mb-4" />
<p className="text-muted-foreground">No announcements yet.</p>
<p className="text-sm text-muted-foreground mt-2">
Check back later for updates
</p>
</div>
</CardContent>
</Card>

<Card>
<div className="grid gap-6 md:grid-cols-2 lg:grid-cols-3">
<Card className="md:col-span-2 lg:col-span-3">
<CardHeader>
<CardTitle>Quick Actions</CardTitle>
<CardDescription>
Common tasks and shortcuts
</CardDescription>
</CardHeader>
<CardContent>
<div className="space-y-3">
<div className="flex items-center justify-between p-3 rounded-lg border">
<div>
<p className="font-medium">View Materials</p>
<p className="text-sm text-muted-foreground">Access training resources</p>
</div>
<BookOpen className="h-4 w-4 text-muted-foreground" />
</div>
<div className="flex items-center justify-between p-3 rounded-lg border">
<div>
<p className="font-medium">Join Contests</p>
<p className="text-sm text-muted-foreground">Participate in competitions</p>
</div>
<Trophy className="h-4 w-4 text-muted-foreground" />
</div>
<div className="flex items-center justify-between p-3 rounded-lg border">
<div>
<p className="font-medium">Check Leaderboard</p>
<p className="text-sm text-muted-foreground">See your ranking</p>
</div>
<Users className="h-4 w-4 text-muted-foreground" />
</div>
<div className="flex flex-col gap-3">
<a href={`/protected/trainings/${trainingIdNumber}/materials`}>
<button className="flex items-center gap-2 w-full px-4 py-2 rounded border hover:bg-muted transition">
<BookOpen className="h-5 w-5 text-muted-foreground" />
<span className="font-medium">Materials</span>
</button>
</a>
<a href={`/protected/trainings/${trainingIdNumber}/contests`}>
<button className="flex items-center gap-2 w-full px-4 py-2 rounded border hover:bg-muted transition">
<Trophy className="h-5 w-5 text-muted-foreground" />
<span className="font-medium">Contests</span>
</button>
</a>
<a href={`/protected/trainings/${trainingIdNumber}/leaderboard`}>
<button className="flex items-center gap-2 w-full px-4 py-2 rounded border hover:bg-muted transition">
<Users className="h-5 w-5 text-muted-foreground" />
<span className="font-medium">Leaderboard</span>
</button>
</a>
</div>
</CardContent>
</Card>
Expand Down
30 changes: 11 additions & 19 deletions src/components/training/TrainingNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,9 @@ import Link from "next/link";
import React from "react";
import { Button } from "@/components/ui/button";
import { cn } from "@/lib/utils";
import { Home, BookOpen, Trophy, Users } from "lucide-react";

export type TrainingNavLink = {
href: string;
label: string;
};

export async function TrainingNavigation({
export function TrainingNavigation({
trainingId,
className = "",
}: {
Expand All @@ -19,17 +15,11 @@ export async function TrainingNavigation({
// Fetch permissions for the user

// Define navigation links
const links: TrainingNavLink[] = [
{ href: `/protected/trainings/${trainingId}`, label: "Overview" },
{
href: `/protected/trainings/${trainingId}/materials`,
label: "Materials",
},
{ href: `/protected/trainings/${trainingId}/contests`, label: "Contests" },
{
href: `/protected/trainings/${trainingId}/leaderboard`,
label: "Leaderboard",
},
const links = [
{ href: `/protected/trainings/${trainingId}`, label: "Overview", icon: <Home className="w-4 h-4" /> },
{ href: `/protected/trainings/${trainingId}/materials`, label: "Materials", icon: <BookOpen className="w-4 h-4" /> },
{ href: `/protected/trainings/${trainingId}/contests`, label: "Contests", icon: <Trophy className="w-4 h-4" /> },
{ href: `/protected/trainings/${trainingId}/leaderboard`, label: "Leaderboard", icon: <Users className="w-4 h-4" /> },
];

// Only show links the user has permission for, or always Overview if any permission
Expand All @@ -42,9 +32,11 @@ export async function TrainingNavigation({
variant="ghost"
size="sm"
asChild
className="font-medium"
className="font-medium flex items-center gap-2"
>
<Link href={link.href}>{link.label}</Link>
<Link href={link.href} className="flex items-center gap-2">
{link.icon} {link.label}
</Link>
</Button>
))}
</nav>
Expand Down