pattern.json enhanced with ready-to-use responses API payload section#68
Open
filip-komarzyniec wants to merge 1 commit into
Open
pattern.json enhanced with ready-to-use responses API payload section#68filip-komarzyniec wants to merge 1 commit into
filip-komarzyniec wants to merge 1 commit into
Conversation
filip-komarzyniec
force-pushed
the
enhance_rag_pattern_output_with_responses_api_payload
branch
2 times, most recently
from
ee5b514 to
52572c4
Compare
| "provider_id": self.ogx_vector_io_provider_id, | ||
| "provider_type": evaluation_result.rag_params["vector_io_provider_type"], | ||
| "vector_store_id": evaluation_result.collection, | ||
| "vector_store_name": "TBD", |
Collaborator
Author
There was a problem hiding this comment.
The ADR specified here the name as assigned in the ConfigMap. It proves really problematic to obtain. How can we simplify this @LukaszCmielowski
Signed-off-by: Filip Komarzyniec <fkomarzy@redhat.com> Signed-off-by: Filip Komarzyniec <fkomarzy@redhat.com> Signed-off-by: Filip Komarzyniec <fkomarzy@redhat.com> Signed-off-by: Filip Komarzyniec <fkomarzy@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
filip-komarzyniec
force-pushed
the
enhance_rag_pattern_output_with_responses_api_payload
branch
from
52572c4 to
ed31b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief summary of changes
Motivation
Why is this change needed?
Changes
Testing
How did you test this?
Checklist