Skip to content

feat(cli): add version info to ado get operators #785

Open
AlessandroPomponio wants to merge 4 commits intomainfrom
ap_778_update_operator_versions
Open

feat(cli): add version info to ado get operators #785
AlessandroPomponio wants to merge 4 commits intomainfrom
ap_778_update_operator_versions

Conversation

@AlessandroPomponio
Copy link
Copy Markdown
Member

Resolves #778

Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
@AlessandroPomponio
Copy link
Copy Markdown
Member Author

@michael-johnston I left the version of detect_anomalous_series at 1.0 as it was the only one setting a value. With that said, I still think we should change it, as it's not following fully semver and it's a random value.

Copy link
Copy Markdown
Member

@michael-johnston michael-johnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure for RandomWalk and RayTune that the method used for the version in the function is the same as they use in CLASS.operatorIdentifer.

RayTune change here does not match.

It may be worth going one step further here and adding a version method to the class and use that - so at least we don't have two different places deciding what the version is.

@michael-johnston
Copy link
Copy Markdown
Member

I think the other problematic aspect is that if you get operatorIdentifier from an operation then

ado get operator $OPERATOR_IDENTIFIER --details

fails. I think ado get operator should check against both basename and identifier.

Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
@AlessandroPomponio
Copy link
Copy Markdown
Member Author

I think the other problematic aspect is that if you get operatorIdentifier from an operation then

ado get operator $OPERATOR_IDENTIFIER --details

fails. I think ado get operator should check against both basename and identifier.

I see - at the same time it feels like the operatorIdentifier that we print isn't just the identifier, rather the identifier + version information. It also follows a potentially (typically?) different logic for generating the identifier, which adds to the confusion. For example we generate randomwalk-$VERSION while the function is registered as random_walk, same goes for raytune-$VERSION vs ray_tune.

we should have everything behave the same

@DRL-NextGen
Copy link
Copy Markdown
Member

DRL-NextGen commented Apr 7, 2026

Checks Summary

Last run: 2026-04-07T08:47:12.667Z

Code Risk Analyzer vulnerability scan found 5 vulnerabilities:

Severity Identifier Package Details Fix
🔷 Medium CVE-2026-34756 vllm
vLLM: Unauthenticated OOM Denial of Service via Unbounded n Parameter in OpenAI API ServerGHSA-3mwp-wvh9-7528

vllm:0.18.0
0.19.0
🔷 Medium CVE-2026-34753 vllm
vLLM: Server-Side Request Forgery (SSRF) in download_bytes_from_url GHSA-pf3h-qjgv-vcpr

vllm:0.18.0
0.19.0
🔷 Medium CVE-2026-34755 vllm
vLLM: Denial of Service via Unbounded Frame Count in video/jpeg Base64 ProcessingGHSA-pq5c-rjhq-qp7p

vllm:0.18.0
0.19.0
◻ Unknown CVE-2026-34450 anthropic
Claude SDK for Python has Insecure Default File Permissions in Local Filesystem Memory ToolGHSA-q5f5-3gjm-7mfm

anthropic:0.86.0->anthropic:0.86.0,vllm:0.18.0
0.87.0
◻ Unknown CVE-2026-34452 anthropic
Claude SDK for Python: Memory Tool Path Validation Race Condition Allows Sandbox EscapeGHSA-w828-4qhx-vxx3

anthropic:0.86.0->anthropic:0.86.0,vllm:0.18.0
0.87.0

Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
@michael-johnston
Copy link
Copy Markdown
Member

If we have identifier mean the "name" of the operator (ray_tune etc.) then where will we put the version info?

@AlessandroPomponio
Copy link
Copy Markdown
Member Author

If we have identifier mean the "name" of the operator (ray_tune etc.) then where will we put the version info?

I think we should have a different field, called operatorVersion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: the operator name shown in ado get operators is not same as operatorIdentifier in an operation

3 participants