Check for mouse events also on touch devices#295
Open
clopez wants to merge 1 commit intoHumbleSoftware:mainfrom
Open
Check for mouse events also on touch devices#295clopez wants to merge 1 commit intoHumbleSoftware:mainfrom
clopez wants to merge 1 commit intoHumbleSoftware:mainfrom
Conversation
Member
|
@clopez thanks for the reference! This relates to #271 and several other issues. The issue is, for all touch devices, having both sets of event handlers will trigger the handlers multiple times (per single event). The reference you suggest mentions e.preventDefault to stop propagation of the synthetic click events. Do you know if this actually works? And if it also works for the mouse events? I don't have a touch + mouse device, but it might be possible for me to debug this myself using chrome's simulated touch events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if a device has touch capabilities (most modern laptops have) the user can still be using the device with a mouse. So install the mouse handler events also for touch-capable devices.
More info: https://hacks.mozilla.org/2013/04/detecting-touch-its-the-why-not-the-how/