chore: introduced local build scripts#2
Open
alicanerdogan wants to merge 2 commits intoHumanComputingInc:mainfrom
Open
chore: introduced local build scripts#2alicanerdogan wants to merge 2 commits intoHumanComputingInc:mainfrom
alicanerdogan wants to merge 2 commits intoHumanComputingInc:mainfrom
Conversation
AYM1607
requested changes
Dec 5, 2024
Contributor
AYM1607
left a comment
AYM1607
left a comment
There was a problem hiding this comment.
Thanks! This is great, looks good overall. I'll merge this if we can get rid of the dependency on your home path. Could we also pass just the name of the artifact as an optional argument to the script? That'd make it okay to have the output of the firmware be a static directory relative to the script.
| #!/bin/bash | ||
| set -ex | ||
|
|
||
| SOURCE_DIR=$(pwd) |
Contributor
There was a problem hiding this comment.
Use "$( dirname -- "${BASH_SOURCE[0]}" )" instead? Also, let's not depend on your home path :)
alicanerdogan
force-pushed
the
local-build-scripts
branch
5 times, most recently
from
9175ccb to
fef44b6
Compare
alicanerdogan
force-pushed
the
local-build-scripts
branch
from
fef44b6 to
a3d8954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following change includes scripts that help generating firmware files in local machine. This is an alternative to the GitHub actions. One advantage of using local builds is shortened feedback cycle between builds.
The build script leverages docker image for zmk arm builds. The integrity of the generated firmware files have been verified using
cmpandsha256sum.