fix: error when playing notification sounds in quick succession#36
Open
Stone-Red-Code wants to merge 2 commits intodevfrom
Open
fix: error when playing notification sounds in quick succession#36Stone-Red-Code wants to merge 2 commits intodevfrom
Stone-Red-Code wants to merge 2 commits intodevfrom
Conversation
HueByte
requested changes
Feb 26, 2026
| } | ||
| catch (Exception ex) | ||
| { | ||
| _lock.Release(); |
Owner
There was a problem hiding this comment.
The release should be moved to finally block
Currently we release it only on the exception, meaning the successful path will keep it locked (releasing on event is fragile)
Collaborator
Author
There was a problem hiding this comment.
The problem with that is that await _player.Play(_resolvedSoundPath!); doesn't block until the audio has finished playing.
That's why I'm waiting for PlaybackFinished.
I know this isn't the best solution, but the library doesn't give us many options.
| public NotificationSoundService(NotificationConfig config) | ||
| { | ||
| _config = config; | ||
| _player.PlaybackFinished += (s, e) => _lock.Release(); |
Owner
There was a problem hiding this comment.
Got some trust issues with that, lets just release the lock in finally block
Owner
There was a problem hiding this comment.
Overall issues imo with event based release:
- If Completed never fires -> deadlock
- If Completed fires twice ->
SemaphoreFullException - If the event handler throws before Release() -> deadlock
- If someone refactors and changes event ordering -> subtle bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes errors when playing notification sounds in quick succession.
This fix may cause notification sounds to be delayed if the previous sound is still playing, but it prevents errors and ensures all notifications are heard
Fixes #20