Skip to content

Redesign pre-login pages, add blog and contribute routes#97

Open
hendriebeats wants to merge 18 commits into
masterfrom
updated-non-login-pages
Open

Redesign pre-login pages, add blog and contribute routes#97
hendriebeats wants to merge 18 commits into
masterfrom
updated-non-login-pages

Conversation

@hendriebeats

@hendriebeats hendriebeats commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Overhauls the home page, adds a blog article page, and adds a contribute page — all the public-facing (non-login) pages. Introduces a shared pre-login.css stylesheet, a reusable header partial, floating box animations, and scroll-reveal on the home page.

Reviewer Q&A

Shared CSS (pre-login.css)
home.css now just imports pre-login.css — all pre-login page styles live in one file so the home, blog, and contribute pages share layout primitives, typography, and the .button-3d component without duplication.

pre-login-header.html partial
The old home page had its own inline <header> + mobile nav <dialog>. Extracting it into a partial means the blog and contribute pages get the same header without copy-paste.

Floating box animations / scroll-reveal
The seven floating-box-*.png images are decorative elements that animate on a float keyframe loop; the JS-driven .reveal class triggers fadeInUp as sections enter the viewport.

home.css reduced to one line
The old home-specific styles were either deleted (superseded by the new design) or moved into pre-login.css. The import stub keeps the <link> in home.html working without a path change.

logInfoSH user in new route handlers
Consistent with Home.hs and Signup.hs — the pattern logs the requesting user (or Nothing) on each page hit.

e.stopPropagation() removed from invite keydown handler (studyGroup.js)
It was preventing the Enter key event from reaching HTMX's form-submit trigger. Removing it lets the form submit correctly without side effects.

base.html whitespace / self-closing tags
Formatting-only change to the <head> font links — no functional difference.

README.md direnv allow steps
Two missing setup steps that tripped up new contributors; added to the numbered list.

Comment thread backend/templates/notAuthorized.html Outdated
</a>
</div>
<img src="{{base}}/static/img/meme.png" class="image" >
<img src="{{base}}/static/img/meme.png" class="image" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The / at the end of the tag like that isn't good. At least from what I've read. Never tested it myself.

Comment thread backend/templates/notAuthorized.html Outdated
<li><a href="https://experiencethehope.com/equipping" target="_blank">Equipping</a></li>
<li><a href="https://messaging.subsplash.com/25FXCW/auth" target="_blank">Messaging</a></li>
<li>
<a href="https://experiencethehope.com/teaching" target="_blank"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I like this formatting...

Comment thread backend/templates/profile.html Outdated
<header id="header">
<a class="logo" href="{{base}}/">
<img class="logo" src="{{base}}/static/img/p215-circle.svg" >
<img class="logo" src="{{base}}/static/img/p215-circle.svg" />

@boxyoman boxyoman Apr 5, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the / at the end

Comment thread backend/templates/profile.html Outdated
{% include "profile/form.html" %}

<br>
<br />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the /

Comment thread backend/templates/profile.html Outdated
{% include "footer.html" %}

{% endblock %}
{% include "footer.html" %} {% endblock %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be on seprate lines.

Comment thread backend/templates/signup.html Outdated
Take the complexity out of Bible study and delve deeper into the Word
with others
</p>
<img src="{{base}}/static/img/laptop-mockup.png" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the /

Comment thread backend/templates/studies.html Outdated
{% extends "base.html" %} {% block content %}
<header id="header">
<img src="{{base}}/static/img/p215-circle.svg" class="logo">
<img src="{{base}}/static/img/p215-circle.svg" class="logo" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the /

Comment thread backend/templates/studies.html Outdated
<div class="row share" id="share-{{share.token}}">
<div>{{ share.groupStudyName }}</div>
<div
{%

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't like this formatting at all. That's true for pretty much everything on this page.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reset the whole "Studies" page to your original

Comment thread backend/static/styles/styles.css Outdated
display: flex;
background:
url("/htmx/static/img/background-blue-circles.png") 50%/cover no-repeat,
background: url("/htmx/static/img/background-blue-circles.png") 50% / cover

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, I think /htmx is wrong. It's my fault, but still wrong.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you want me to do about this...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of /htmx/static/img/background-blue-circles.png it should be /static/img/background-blue-circles.png

@@ -0,0 +1,21 @@
module Api.Htmx.BlogArticleHistoryOfOutlining where

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably combine these all into one module so we don't need to make a different module for every static page we want to make.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'm assuming that's something you'd do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it. It's nothing crazy. Instead of putting getBlogArticleHistoryOfOutlining and getContribute in different files, you put them in the same file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear you, but I don't know how to do that... :(

@boxyoman

boxyoman commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

image
I don't think the button is supposed to be over like that.

Comment thread backend/templates/login.html Outdated
@@ -1,36 +1,35 @@
{% extends "base.html" %}
{% block content %}
{% extends "base.html" %} {% block content %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks this page.

Comment thread backend/templates/notAuthorized.html Outdated
@@ -1,5 +1,4 @@
{% extends "base.html" %}
{% block content %}
{% extends "base.html" %} {% block content %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break this page.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I reset this

Comment thread backend/templates/notFound.html Outdated
@@ -1,5 +1,4 @@
{% extends "base.html" %}
{% block content %}
{% extends "base.html" %} {% block content %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break this page.

Comment thread backend/templates/passwordReset.html Outdated
@@ -1,35 +1,32 @@
{% extends "base.html" %}
{% block content %}
{% extends "base.html" %} {% block content %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break this page.

Comment thread backend/templates/profile.html Outdated
@@ -1,8 +1,7 @@
{% extends "base.html" %}
{% block content %}
{% extends "base.html" %} {% block content %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break this page.

Comment thread backend/templates/signup.html Outdated
{% extends "base.html" %}
{% block content %}
<script async defer src="https://cdn.jsdelivr.net/npm/altcha/dist/altcha.min.js" type="module"></script>
{% extends "base.html" %} {% block content %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break this page.

Comment thread backend/templates/studies.html Outdated
@@ -1,7 +1,6 @@
{% extends "base.html" %}
{% block content %}
{% extends "base.html" %} {% block content %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break this page.

Comment thread backend/templates/contribute.html Outdated
</li>
<li>
<strong>Connect with Us</strong>: Reach out via
<a href="mailto:contact@yourproject.com" target="_blank">email</a> to introduce yourself

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use developer@p215.church for the email here.

Comment thread backend/templates/contribute.html Outdated
<li>
<strong>Explore Our Repository</strong>: Visit our
<a href="https://github.com/HopeCommunityChurch/project-2-15" target="_blank"
>GitHub page</a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally you wouldn't call this a github page. There's actually a feature in github called github pages and people will probably think we used that to make a page, which we didn't. You can probably just word it as "visit the repo" or something like that.

@boxyoman

boxyoman commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

@hendriebeats From what I can tell, whatever you're using for auto formatting is causing lots of problems. You'll probably have to disable it.

@hendriebeats

Copy link
Copy Markdown
Contributor Author

Ok, @boxyoman, I made all the changes except for the ones I'd imagine you'd fix. How does it look now? I'll either remove or dramatically pair down my auto formatter

@boxyoman

Copy link
Copy Markdown
Contributor

@hendriebeats Reviewed it again.

@hendriebeats

Copy link
Copy Markdown
Contributor Author

OK @boxyoman I think i did it

@hendriebeats

Copy link
Copy Markdown
Contributor Author

@boxyoman checking back in on this branch. I see merge conflicts above. Do you have a sense of the best next steps to get this branch (eventually) merged? I'll plan to not use the formatter I was using before.

@boxyoman

Copy link
Copy Markdown
Contributor

@boxyoman checking back in on this branch. I see merge conflicts above. Do you have a sense of the best next steps to get this branch (eventually) merged? I'll plan to not use the formatter I was using before.

@hendriebeats You can try resolving the conflicts. I can then review it again. (It's not impossible it's easy to just restart).

@hendriebeats

Copy link
Copy Markdown
Contributor Author

@boxyoman fixed the merge conflicts

@hendriebeats hendriebeats force-pushed the updated-non-login-pages branch 3 times, most recently from 56732c1 to 59af445 Compare February 19, 2026 08:55
@hendriebeats hendriebeats force-pushed the updated-non-login-pages branch from 59af445 to 15603b2 Compare February 19, 2026 08:56
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Animate hero heading, subtext, CTA, and image on page load with fadeInUp
- Add gradient background to hero section
- Add SVG wave dividers between hero/community and community/study-anywhere sections
- Add IntersectionObserver scroll-reveal for community, study-anywhere, and custom-study-blocks sections
- Set page-level and community section background colours for seamless blending
@hendriebeats hendriebeats changed the title Updated non login pages Redesign pre-login pages, add blog/contribute routes Feb 23, 2026
@hendriebeats hendriebeats changed the base branch from main to master February 23, 2026 03:00
hendriebeats and others added 3 commits February 22, 2026 22:03
- Fix translatey typo → translateY in pre-login.css
- Remove duplicate @media (max-width: 1130px) block in pre-login.css
- Remove shadowed justify-content: center in .page-hero
- Remove spurious extra </div> in home.html
- Add focusable="false" to decorative wave SVGs
- Remove e.stopPropagation() from invite Enter keydown handler
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@hendriebeats hendriebeats force-pushed the updated-non-login-pages branch from df66781 to b54c548 Compare February 23, 2026 03:05
@hendriebeats hendriebeats changed the title Redesign pre-login pages, add blog/contribute routes Redesign pre-login pages, add blog and contribute routes Feb 23, 2026
…lity

- Replace instant translateY hover on .button-3d with a single-press
  bounce keyframe (presses down, slight recovery, settles)
- Add z-index: 0 to .section-content so its z-index: -1 floating box
  children paint behind content but in front of the section background
  gradient (previously they fell behind the root stacking context and
  were invisible)
- Wrap all "BEGIN YOUR JOURNEY", "SIGN UP", and "CREATE A STUDY"
  buttons on the home page and blog article in <a href="/signup"> so
  they actually navigate to the signup page
- Switch header logo to a <picture> element: shows the full P215.png
  wordmark on wider screens (≥765 px) and the circle SVG on mobile
- Add display:block to .logo to eliminate inline-image baseline gap
- Replace floating-box-1.png with updated asset; remove misplaced
  pre-login-pages/P215.png (now served from /static/img/P215.png)
@hendriebeats hendriebeats added the Siee: XL / Too large 1,000+ lines: Hard to review; often requires staged PRs or special review strategy. label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Siee: XL / Too large 1,000+ lines: Hard to review; often requires staged PRs or special review strategy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants