Add Cmd+Shift+Z as redo keybinding#131
Open
hendriebeats wants to merge 1 commit into
Open
Conversation
Cmd+Shift+Z is the standard redo shortcut on macOS. Adding it alongside the existing Mod-Y binding improves muscle-memory compatibility for Mac users. ProseMirror's Mod- prefix handles cross-platform mapping automatically (Ctrl on Windows/Linux, Cmd on macOS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Mod-Shift-Z(Cmd+Shift+Z on macOS, Ctrl+Shift+Z on Windows/Linux) as a redo shortcut in the editor. This is the standard redo binding on macOS and complements the existingMod-Ybinding.Reviewer notes
Why two identical changes?
The editor has two separate keymap registrations — one in
questionPopupand one inP215Editor— so the binding must be added to both to work in all editor contexts.Why keep
Mod-Yas well?Ctrl+Yis the conventional redo shortcut on Windows; removing it would break that expectation.