Add HTMLButtonElement interface to custom element test by xiaoyu3x · Pull Request #83 · Honry/demo

xiaoyu3x · 2018-03-19T08:38:28Z

All attributes use built-in way

Honry · 2018-03-21T03:16:17Z

+<!DOCTYPE html>
+<html>
+<head>
+<title>Custom Elements: CEReactions on Element interface</title>


s/Element/HTMLButtonElement/g

Element has been replaced.

Honry · 2018-03-21T03:17:24Z

@@ -0,0 +1,114 @@
+<!DOCTYPE html>
+<html>
+<head>


head, html, body labels are unnecessary.

Labels head and html have been omitted.

Honry · 2018-03-21T03:19:03Z

+<body>
+<script>
+
+//IDL attribute reflects the content attribute of the same name inside the parent Node


Actually I can't understand the comments.

Notes are updated.

Honry · 2018-03-21T03:20:05Z

+}
+
+//IDL attribute reflects the content attribute of the same name which depends another attribute inside the parent Node
+function testReflectAttributeWithDepAttributeWithContentValues(subJsAttrName, subConAttrName, depAttrName, subJsAttrValue1, subConAttrValue1, subJsAttrValue2, subConAttrValue2, depAttrValue, name, subElementName, pareElementName, interfaceName) {


function name is tooooo long.

The name is cutted

Honry · 2018-03-21T06:33:43Z

+<script src="/tests/custom-elements/resources/testharness.js"></script>
+<script src="/tests/custom-elements/resources/testharnessreport.js"></script>
+<script src="./custom-elements-helpers.js"></script>
+<script src="./reactions.js"></script>


remove './'

'./' has been removed.

Honry · 2018-03-21T06:37:08Z

+
+//In parent node, sub node's observeAttribute can enqueue by changing attribute value 
+//Re->reflect, At->attribute, P->parent, Co->content
+function testReAtWithPNodeWithCoValues(jsAtName, coAtName, jsAtValue1, coAtValue1, jsAtValue2, coAtValue2, name, elementName, pElementName, interfaceName) {


How about testReflectAttrWithContentValuesAndPNode? And replace the second line of comment with "Test reflect attribute with content values and parent node", not sure if I am right.

Your suggestion is good, I has updated.

Honry · 2018-03-21T06:37:57Z

+    parentElement.parentNode.removeChild(parentElement);
+}
+
+//Package JS attribute with parent Node to test


Has updated.

Honry · 2018-03-21T06:38:03Z

+}
+
+//In parent node, sub node's observeAttribute which depends another attribute can enqueue by changing attribute value
+//Re->reflect, At->attribute, De->depdent, Co->content


Honry · 2018-03-21T06:38:10Z

+    parentElement.parentNode.removeChild(parentElement);
+}
+
+//Package JS attribute depends another atrribute


Honry · 2018-03-21T06:38:46Z

+    testReAtWithDeAtWithCoValues(jsAtName, coAtName, deAtName, jsAtValue1, jsAtValue1, jsAtValue2, jsAtValue2, deAtValue, name, elementName, pElementName, interfaceName);
+}
+
+testReflectAttributeWithContentValues('autofocus', 'autofocus', true, 'true', false, 'false', 'autofocus on HTMLButtonElement', 'button', HTMLButtonElement);


move following test function calls to the beginning of <script>

Move function calls to the beginning of <script>

Honry · 2018-03-21T07:33:06Z

@@ -0,0 +1,112 @@
+<!DOCTYPE html>
+<title>Custom Elements: CEReactions on HTMLButtonElement interface</title>
+<meta name="author" title="Zhang xiaoyu" href="xiaoyux.zhang@intel.com">


s/xiaoyu/Xiaoyu

Has updated

Honry · 2018-03-21T07:34:21Z

+
+//In parent node, sub node's observeAttribute can enqueue by changing attribute value 
+//Test reflect attribute with content values and parent node
+function testReAtWithPNodeWithCoValues(jsAtName, coAtName, jsAtValue1, coAtValue1, jsAtValue2, coAtValue2, name, elementName, pElementName, interfaceName) {


You didn't update the function name.

The function name has been updated

Honry · 2018-03-21T07:34:48Z

+}
+
+//Package refect attribute with parent Node
+function testReAtWithPNode(jsAtName, coAtName, jsAtValue1, jsAtValue2, name, elementName, pElementName, interfaceName) {


Honry · 2018-03-21T07:34:55Z

+
+//In parent node, sub node's observeAttribute which depends another attribute can enqueue by changing attribute value
+//Test reflect attribute with content values and dependent attribute 
+function testReAtWithDeAtWithCoValues(jsAtName, coAtName, deAtName, jsAtValue1, coAtValue1, jsAtValue2, coAtValue2, deAtValue, name, elementName, pElementName, interfaceName) {


Honry · 2018-03-21T07:35:24Z

+
+    test(() => {
+        var element = define_build_in_custom_element([coAtName], interfaceName, elementName);
+        var instance = document.createElement(elementName, { is: element.name});


need whitespace after element.name

Please check other {}

Whitespace has updated

Honry · 2018-03-21T07:36:16Z

+}
+
+//Package reflect attribute with dependent attribute
+function testReAtWithDeAt(jsAtName, coAtName, deAtName, jsAtValue1, jsAtValue2, deAtValue, name, elementName, pElementName, interfaceName) {


xiaoyu3x force-pushed the add-custom-element-button branch 6 times, most recently from cea39f6 to cef1df4 Compare March 21, 2018 01:15

Honry reviewed Mar 21, 2018

View reviewed changes

xiaoyu3x force-pushed the add-custom-element-button branch from cef1df4 to 58fba0d Compare March 21, 2018 06:28

Honry reviewed Mar 21, 2018

View reviewed changes

xiaoyu3x force-pushed the add-custom-element-button branch from 58fba0d to 56efcb3 Compare March 21, 2018 07:21

Honry reviewed Mar 21, 2018

View reviewed changes

Add HTMLButtonElement interface to custom element test

a6176f6

xiaoyu3x force-pushed the add-custom-element-button branch from 56efcb3 to a6176f6 Compare March 21, 2018 08:14

Conversation

xiaoyu3x commented Mar 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants