Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All 11 Aqua checks pass; adding to prevent regressions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace bare `using` statements with explicit name lists, and change `using Base: @nLoops, @nexprs, @nref, @nif` to `import Base.Cartesian: ...` to correctly attribute their owner. Adds test_explicit_imports to the test suite to prevent regressions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix two broken symbols in src/:
- Replace indmin_mismatch with argmin_mismatch (renamed in RegisterCore)
- Fix pat_rotation wrapper: replace eye() with Matrix{Float64}(I, n, n)
Add tests for previously uncovered functions:
- uisvalid and uclamp!
- qfit all-below-threshold early return
- optimize_per_aperture
- mms2fit!
- pat_rotation(array, array) convenience wrapper
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Rewrote all exported function docstrings: imperative mood, indented signatures, documented return types, fixed the qbuild u0→umin arg name mismatch, fixed mms2fit! dangling reference to fixed_λ/auto_λ (now qualified as RegisterPenalty.*), clarified uisvalid domain condition, documented N-dimensionality constraint in mms2fit!, and added jldoctest examples for principalaxes, uisvalid, and uclamp! - Added Documenter.jl as a test dependency with a Doctests testset Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- README.md: badges (CI, Codecov, stable/dev docs), HolyLabRegistry install instructions, two quick-start examples, workflow overview - docs/: Project.toml, make.jl, src/index.md (concepts + workflow), src/api.md (full API reference via @docs blocks) - CI.yml: add docs job using julia-docdeploy with DOCUMENTER_KEY - Convert five docstring examples from unverified julia blocks to jldoctest blocks (qfit, qbuild, optimize_per_aperture, mms2fit!, pat_rotation); update DocTestSetup to include RegisterCore Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Base.tail is not a public API; ExplicitImports CI was flagging it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
===========================================
+ Coverage 63.49% 75.46% +11.96%
===========================================
Files 1 1
Lines 326 326
===========================================
+ Hits 207 246 +39
+ Misses 119 80 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignorejldoctestblocks (verified by CI)docs/with concepts page and full API referencejulia-docdeploy)Test plan
gh-pagesbranch is created🤖 Generated with Claude Code