Conversation
- Add Aqua to [extras]/[targets] with compat bound "0.8" - Add compat entries for Random and Test stdlib extras - Add Aqua.test_all testset to runtests.jl - Add Aqua badge to README Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace bare `using Interpolations, OffsetArrays` with explicit `using Interpolations: Interpolations, AbstractInterpolation` and `using OffsetArrays: OffsetArrays, OffsetArray` - Switch `IdentityUnitRange` from an import to qualified `Base.IdentityUnitRange` - Add ExplicitImports as a test dependency (extras/targets) with compat "1" - Add ExplicitImports testset to prevent regressions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove two `iterate` methods from symrange.jl that defined `CenterIndexedArrays.iterate` instead of `Base.iterate` and were never called (iteration relied on the AbstractUnitRange fallback). The methods also had a bug: the `r.n == 0` guard treated SymRange(0) as empty, when it actually contains a single element (0). New tests cover: SymRange(n::Integer) with non-Int input, SymRange(0) iteration, and interpolation-backed CenterIndexedArray indexing with both integer and fractional indices. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…constructor coverage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace dead Travis CI badge with GitHub Actions, add Codecov and JuliaHub version badges. Add installation section, SymRange explanation, and Interpolations integration section. Convert all code examples to jldoctest blocks verified against a live Julia session. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
timholy
left a comment
timholy
left a comment
There was a problem hiding this comment.
Looks very good, just minor comments.
I should note that while I can see there is one issue, GitHub won't show it to me! It's not visible to me when I click on "Issues"!
| version: | ||
| - '1.6' | ||
| - '1.1' | ||
| - '1.10' |
There was a problem hiding this comment.
If the various actions are new enough (e.g., setup-julia@3), this should become min, as that means it will always test the minimum Julia version consistent with the [compat], which is more generic than testing a specific release.
There was a problem hiding this comment.
Because, it has an error in version 1.6 and 1.1.
There was a problem hiding this comment.
Right, I agree with changing this to 1.10. But to future-proof this, write it as 'min'. 'min' always matches whatever is in the Project.toml [compat] so you don't have to keep changing it both places.
For that to work we need to be using at least v2 of setup-julia
There was a problem hiding this comment.
I understood. Which one is recommended v3 or v2 of setup-julia?
|
|
||
| @inline Base.unsafe_indices(r::SymRange) = (r,) | ||
|
|
||
| function iterate(r::SymRange) |
There was a problem hiding this comment.
Is the motivation for deleting these that they're redundant with the generic method for AbstractUnitRange? That's quite plausible, and deleting code is always nice.
There was a problem hiding this comment.
Yes, Claude suggested this.
| name = "CenterIndexedArrays" | ||
| uuid = "46a7138f-0d70-54e1-8ada-fb8296f91f24" | ||
| authors = ["Tim Holy <tim.holy@gmail.com>"] | ||
| version = "0.2.4" |
There was a problem hiding this comment.
If you're deleting deprecations, this is a breaking change. Once you're finished with this overhaul, I think we should go straight to 1.0: I don't see anything this package is missing.
There was a problem hiding this comment.
Yes, I plan to make version up and register than go on to the next package.
|
Here's a screenshot. Weird, right? 
|
|
I've also been doing "combined PRs" like this, although the deletion of the That's just a comment for future reference, no need to make changes here. If you do squash, make sure you preserve the most informative comments. |
I tried to post this again but still it doesn't work. This was a 'design review report'. I will try it again later. |
2 participants
No description provided.