Fix failing CI: schema contract test, calendar menu role, flaky e2e#4
Merged
Conversation
Three independent failures were red on main: - Pipeline unit test test_schema_contract expected _to_event_row to return a dict, but it now returns a (row, superseded_id) tuple. Unpack it. - E2E "Add to calendar"/"Add reminder" expected role=button, but the <summary> disclosure toggle exposed neither button nor link (Playwright sees the <details> as a group). Give the <summary> an explicit role="button" so the accessible role matches a disclosure toggle and the native toggle still works. - E2E "calendar shows loading state" failed deterministically on slow CI CPU: the calendar syncs its cursor to the feed's observed day on mount, firing a stray fetch that races the test's Next-month click. Wait for the calendar to settle on May 2026 before exercising the navigation fetch, matching the sibling tests. Drop the racy blockCalendarFetch band-aid. Verified locally: 83/83 pipeline tests, 12/12 e2e, lint clean. The calendar test now passes under 4x/8x/12x CPU throttle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent failures were red on main:
Pipeline unit test test_schema_contract expected _to_event_row to return a dict, but it now returns a (row, superseded_id) tuple. Unpack it.
E2E "Add to calendar"/"Add reminder" expected role=button, but the
an explicit role="button" so the accessible role matches a disclosure toggle and the native toggle still works.
E2E "calendar shows loading state" failed deterministically on slow CI CPU: the calendar syncs its cursor to the feed's observed day on mount, firing a stray fetch that races the test's Next-month click. Wait for the calendar to settle on May 2026 before exercising the navigation fetch, matching the sibling tests. Drop the racy blockCalendarFetch band-aid.
Verified locally: 83/83 pipeline tests, 12/12 e2e, lint clean. The calendar test now passes under 4x/8x/12x CPU throttle.