Add examples parallel_sum and sequential_sum#601
Open
anacrolix wants to merge 1 commit intoHigherOrderCO:mainfrom
Open
Add examples parallel_sum and sequential_sum#601anacrolix wants to merge 1 commit intoHigherOrderCO:mainfrom
anacrolix wants to merge 1 commit intoHigherOrderCO:mainfrom
Conversation
Author
|
Bump |
nicolas-abril
requested changes
Aug 20, 2024
Member
nicolas-abril
left a comment
nicolas-abril
left a comment
There was a problem hiding this comment.
Sorry we didn't get to your PR earlier, I just forgot about it.
We already have a parallel sum example (it just used to have a bad file name).
For the sequential sum, I'd rather it be part of the parallel sum example, with an explanation of the difference between the two and a suggestion for users to try sswapping between the two functions and seeing the difference.
That way it's more educational and also avoids polluting the examples with trivial things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the examples from the README. This makes it much easier to get up and running.
Perhaps the README could refer to the examples directly in a later change.