Conversation
…rbarrue_rate_fits
Author
|
This is likely because we have so much signal w.r.t. background that at the some point the prediction goes negative. Will need to put a lower bound on the signal strength, such that we don't get to this situation. The current code has limits defined for some parameters, can just copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version of unbinned rate fits seems to work.
Main issue: when scanning over the signal strength, Minuit starts at 1.0 as requested, but then starts going to large values, first positive, then negative. After the first evaluation with a large negative value, the POI is set to nan, and it is propagated to the likelihood evaluations. I wasn't really able to debug this yet.