Skip to content

Improve auto-show/hide toolbar#2292

Open
eranl wants to merge 3 commits intoHeliBorg:mainfrom
eranl:auto-toolbar
Open

Improve auto-show/hide toolbar#2292
eranl wants to merge 3 commits intoHeliBorg:mainfrom
eranl:auto-toolbar

Conversation

@eranl
Copy link
Copy Markdown
Contributor

@eranl eranl commented Feb 13, 2026

  1. Auto-show toolbar on any selection change/cursor move (if setting is on)
  2. Only auto-hide toolbar while typing a word (if setting is on)

Should any of this be optional?

Mostly fixes #2281.

@Helium314
Copy link
Copy Markdown
Collaborator

Do the isResumed changes have any noticeable effects, other than for your use in LatinIME? It's used in Suggest, and I don't want to introduce any further bugs there.
Looks like "@return whether we started composing this word by resuming suggestion on an existing string" is incorrect with these changes.


final SettingsValues settingsValues = mSettings.getCurrent();
if (hasSuggestionStripView() && settingsValues.mAutoShowToolbar
&& composingSpanEnd != - 1 && newSelStart != oldSelStart + 1 && newSelStart != oldSelStart - 1 && newSelStart != composingSpanEnd) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference of 1 is how you detect typing? If so, you should also consider that keys can input multiple characters, and this is not only for customized layouts, but normal for some languages.

@Helium314
Copy link
Copy Markdown
Collaborator

Should any of this be optional?

I suspect 2. might be unwanted for some users, so better make it optional. 1. should be fine I think.

@maruuk
Copy link
Copy Markdown

maruuk commented Apr 4, 2026

I think 1 should also be optional. If I type an incorrect word and autocorrect doesn't work, I click on it to select the correct one from the suggestion bar. After this change, I'll have to expand the suggestion bar, which will slow down my typing.

Btw, since you are improving the auto-show/hide toolbar, could you please take a look at these issues? #993 #1855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only show suggestions on typing

3 participants