Conversation
|
Do the |
|
|
||
| final SettingsValues settingsValues = mSettings.getCurrent(); | ||
| if (hasSuggestionStripView() && settingsValues.mAutoShowToolbar | ||
| && composingSpanEnd != - 1 && newSelStart != oldSelStart + 1 && newSelStart != oldSelStart - 1 && newSelStart != composingSpanEnd) { |
There was a problem hiding this comment.
The difference of 1 is how you detect typing? If so, you should also consider that keys can input multiple characters, and this is not only for customized layouts, but normal for some languages.
I suspect 2. might be unwanted for some users, so better make it optional. 1. should be fine I think. |
|
I think 1 should also be optional. If I type an incorrect word and autocorrect doesn't work, I click on it to select the correct one from the suggestion bar. After this change, I'll have to expand the suggestion bar, which will slow down my typing. Btw, since you are improving the auto-show/hide toolbar, could you please take a look at these issues? #993 #1855 |
Should any of this be optional?
Mostly fixes #2281.